[test] Intended behavior for not committing a partial tree in a Transition #33040
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Apr 28, 2025
packages/react-reconciler/src/__tests__/ReactTransition-test.js
Outdated
Show resolved
Hide resolved
|
Comparing: c498bfc...5410fd6 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
changed the title
My brain just has a longer fuse
eps1lon
force-pushed
the
sebbie/transition-commit-partial
branch
from
296a473 to
5410fd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We already have a similar assertion in https://github.com/eps1lon/react/blob/abc59fac23619b5c0354e8472d47dd0726c1cd09/packages/react-reconciler/src/__tests__/ReactTransition-test.js#L789-L790. That test does a lot more so I extracted the important bits that trip up React DevTools.