Skip to content

Root import types from react-native in ReactNativeTypes #33063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coado
Copy link
Contributor

@coado coado commented Apr 30, 2025

Summary

This PR migrates deep import from react-native to the root import. The motivation behind this is that newly introduced package exports in react native are more strict and this import breaks type resolution for ReactNativePrivateInterface.

How did you test this change?

Signals

@react-sizebot
Copy link

Comparing: 408d055...834ed05

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 527.81 kB 527.81 kB = 93.08 kB 93.08 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 633.44 kB 633.44 kB = 111.27 kB 111.27 kB
facebook-www/ReactDOM-prod.classic.js = 671.22 kB 671.22 kB = 117.71 kB 117.71 kB
facebook-www/ReactDOM-prod.modern.js = 661.50 kB 661.50 kB = 116.15 kB 116.15 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactNativeRenderer-dev.fb.js = 678.74 kB 676.47 kB = 110.05 kB 109.78 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 415.48 kB 413.74 kB = 70.94 kB 70.64 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 387.37 kB 385.62 kB = 66.78 kB 66.54 kB
react-native/shims/ReactNativeTypes.js = 7.24 kB 7.21 kB = 2.00 kB 1.98 kB
react-native/implementations/ReactFabric-dev.fb.js = 675.04 kB 670.34 kB = 109.54 kB 108.79 kB
react-native/implementations/ReactFabric-profiling.fb.js = 413.77 kB 410.00 kB = 70.70 kB 70.02 kB
react-native/implementations/ReactFabric-prod.fb.js = 385.59 kB 381.82 kB = 66.56 kB 65.91 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js = 1,036.93 kB 1,024.11 kB = 173.85 kB 171.73 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js = 1,020.60 kB 1,007.79 kB = 171.02 kB 168.88 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js = 597.18 kB 586.14 kB = 104.23 kB 102.24 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js = 591.24 kB 580.20 kB = 103.07 kB 101.08 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js = 568.52 kB 557.48 kB = 100.14 kB 98.19 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js = 563.02 kB 551.98 kB = 99.05 kB 97.10 kB

Generated by 🚫 dangerJS against 834ed05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants