[compiler] Add try/catch to safely read files during healthcheck #33098
+13
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the stability of
react-compiler-healthcheckby wrapping thefs.readFileoperation in a try/catch block.It prevents the script from crashing when a file matched by the glob pattern is deleted or becomes unreadable before being read.
This ensures smoother execution, especially in large codebases with frequently changing files.
How did you test this change?
I ran the
npx react-compiler-healthcheckcommand on several codebases, including scenarios where some files were deleted during execution.Confirmed that:
The spinner continues running and displays warnings for unreadable files.
Valid files are still processed correctly.
The tool no longer crashes due to
fs.readFileerrors.