Skip to content

Fix: Add warning for deprecated second parameter in createContext #33102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Ronitsabhaya75
Copy link

  • Implemented a warning for the deprecated calculateChangedBits parameter in React.createContext()
  • Resolves a TODO comment in ReactContext.js that asked whether to warn about this parameter
  • Added a development-only warning when arguments.length > 1
  • Used arguments.length instead of adding a formal parameter to avoid Flow type issues
  • Warning clearly informs developers that the parameter is deprecated and will be removed in a future version
  • Created test application demonstrating the warning behavior in both development and production environments

This change improves developer experience by providing clear feedback about deprecated APIs, helping developers prepare for future breaking changes. The warning only appears in development mode and doesn't affect production builds.

Test results confirm the implementation works as expected:

  1. Warning shows in development mode when second parameter is used
  2. No warning appears when used correctly (single parameter)
  3. No warnings in production mode

- Implemented a warning for the deprecated  parameter in
  React.createContext() that was mentioned in a TODO comment
- Added a development-only warning when arguments.length > 1
- Used arguments.length instead of a formal parameter to avoid Flow type issues
- Warning indicates that the parameter is deprecated and will be removed
- Created tests in development and production environments to verify behavior

This change improves developer experience by warning about a deprecated
parameter that will be removed in a future version, allowing time for
migration.
@facebook-github-bot
Copy link

Hi @Ronitsabhaya75!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants