[mcp] Add proper web-vitals metric collection #33109
Open
+125
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elicwhite
reviewed
May 2, 2025
| import {StdioServerTransport} from '@modelcontextprotocol/sdk/server/stdio.js'; | ||
| import {z} from 'zod'; | ||
| import {compile, type PrintedCompilerPipelineValue} from './compiler'; | ||
| import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js'; |
There was a problem hiding this comment.
Looks like maybe you have some lint configuration misconfigured
| @@ -29,16 +33,16 @@ const server = new McpServer({ | |||
|
|
|||
| server.tool( | |||
| 'query-react-dev-docs', | |||
| 'Search/look up official docs from react.dev', | |||
| 'This tool lets you search for official docs from react.dev. This always has the most up to date information on React. You can look for documentation on APIs such as <ViewTransition>, <Activity>, and hooks like useOptimistic, useSyncExternalStore, useTransition, and more. Whenever you think hard about React, please use this tool to get more information before proceeding.', | |||
There was a problem hiding this comment.
I saw that @poteto removed "please"s from the prompts in a previous PR
There was a problem hiding this comment.
Yes, I accidentally got myself into merge hell for trying to do mercurial patterns but shawn saved me lol
shwanton
force-pushed
the
improve-web-vitals
branch
from
28562dd to
ad63721
Compare
poteto
reviewed
May 3, 2025
|
|
||
| TEST: ${results.webVitals.inp} |
Comment on lines
+138
to
+141
| for (const selector of selectors) { | ||
| await page.click(selector); | ||
| await delay(500); | ||
| } |
There was a problem hiding this comment.
depending on the number of elements this could be pretty slow. I don't think you need to wait 500ms after every click before clicking again right?
Suggested change
| for (const selector of selectors) { | |
| await page.click(selector); | |
| await delay(500); | |
| } | |
| await Promise.all(selectors.map((selector) => page.click(selector))); | |
| await delay(500); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple things here: