[WIP] Refactoring of the type generation/type assertion for provided variables to support internal use case with shared artifacts. #4429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D48801823 |
alunyov
changed the title
|
@alunyov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D48801823 |
alunyov
added a commit
to alunyov/relay
that referenced
this pull request
Aug 30, 2023
…les to support internal use case with shared artifacts. (facebook#4429) Summary: Pull Request resolved: facebook#4429 Differential Revision: D48801823 Pulled By: alunyov fbshipit-source-id: bcfd9ee731f9314f46d0ccb6953d1e8015c2bda9
alunyov
force-pushed
the
export-D48801823
branch
from
dd0091a to
d1f3f8b
Compare
|
@alunyov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D48801823 |
alunyov
added a commit
to alunyov/relay
that referenced
this pull request
Aug 30, 2023
…les to support internal use case with shared artifacts. (facebook#4429) Summary: Pull Request resolved: facebook#4429 Differential Revision: D48801823 Pulled By: alunyov fbshipit-source-id: 91f7249105ac90652d8c257954dfcc4fa87467af
alunyov
force-pushed
the
export-D48801823
branch
from
d1f3f8b to
82bbc4a
Compare
|
@alunyov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…les to support internal use case with shared artifacts. (facebook#4429) Summary: The main goal is to separate `codegen` and `typegen` for provided variables. Currently, there is an implicit dependency between `typegen` and `codegen` where were generating code for provided variables. The `codegen` expects the local type for provided variables to always be generated as `type ProvidedVariables` so we cam enable inline type assertion as ``` var providedVariables: ProvidedVariables = { ... object with provided variables ... } ``` However, this approach doesn't work well with the `skip_types` option, where the `typegen` block for an operation is completely skipped (without the `skip_types` we would generate a type for `ProvidedVariables` in it), but the type inline assertion still remains in the `relay-codegen`. The proposed solution is to make this dependency explicit by passing the generated provided variables object to the method responsible for generating types. Additionally, the type assertion should only be generated in the `relay-typegen`. --- Pull Request resolved: facebook#4429 Test Plan: TBD Differential Revision: D48801823 Pulled By: alunyov fbshipit-source-id: 556098bb2ad2457d451b5e77bc38fdb568df2d08
|
This pull request was exported from Phabricator. Differential Revision: D48801823 |
alunyov
force-pushed
the
export-D48801823
branch
from
5a630e6 to
04044ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D48801823