Fix raw response type of @semanticNonNull field in inline fragment
#4950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-tengler
force-pushed
the
fix-semantic-types-on-raw-response-type-inline-fragment
branch
from
60d9760 to
101d5f6
Compare
|
The compiler output check failing due to |
tobias-tengler
force-pushed
the
fix-semantic-types-on-raw-response-type-inline-fragment
branch
from
101d5f6 to
3e7bd39
Compare
|
@captbaritone Sorry for the ping, but could you guys take a look at this? It would make our migration to |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks for the fix, and the ping! |
|
I'm actually not sure this approach is correct. Left a comment here: #4949 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4949