Skip to content

Commit

Permalink
Disable flaky unit test RoundRobinSubcompactionsAgainstPressureToken (
Browse files Browse the repository at this point in the history
#13416)

Summary:
The test is [flaky](https://github.com/facebook/rocksdb/actions/runs/13417174378/job/37480755623?fbclid=IwZXh0bgNhZW0CMTEAAR2pj4E1ua6zMxz4FxnPAPLIz011t1ddjaWPbmFlldfSG7dZGjWGVy-mDkg_aem_40kU2iCmcN93WsmzLZxGsA) and my previous [fix](#13347) did not seem to work. It's likely a test set up issue and disable the test for now since RoundRobin compaction style is not used to reduce some test failure noise.

Pull Request resolved: #13416

Test Plan: CI

Reviewed By: hx235

Differential Revision: D70002097

Pulled By: cbi42

fbshipit-source-id: afe0f56363501dab2c9dc297bfbe0dff0ac6aeb3
  • Loading branch information
cbi42 authored and facebook-github-bot committed Feb 21, 2025
1 parent 5139ff5 commit 4c975a7
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion db/db_compaction_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6440,7 +6440,11 @@ TEST_F(DBCompactionTest, PersistRoundRobinCompactCursor) {
}
}

TEST_P(RoundRobinSubcompactionsAgainstPressureToken, PressureTokenTest) {
// FIXME: the test is flaky and failing the assertion
// ASSERT_EQ(num_planned_subcompactions, kNumSubcompactions);
// It's likely a test set up issue, fix if we are to use RoubdRobin compaction.
TEST_P(RoundRobinSubcompactionsAgainstPressureToken,
DISABLED_PressureTokenTest) {
const int kKeysPerBuffer = 100;
const int kNumSubcompactions = 2;
const int kFilesPerLevel = 50;
Expand Down

0 comments on commit 4c975a7

Please sign in to comment.