-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typos in documentation files #13217
base: main
Are you sure you want to change the base?
Conversation
hi, @jowlyzhang @jaykorean! I’ve just submitted a pull request. Could you please review it when you have a chance? I’d appreciate your feedback and any comments. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @zeevick10 thanks for the contribution. Our recent contribution guide has updated to not take typo only changes: https://github.com/facebook/rocksdb/wiki/RocksDB-Contribution-Guide
Hi @zeevick10! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@jowlyzhang @jaykorean Happy holidays!🙂 Could you check this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @zeevick10 thanks for the contribution. Our recent contribution guide has updated to not take typo only changes: https://github.com/facebook/rocksdb/wiki/RocksDB-Contribution-Guide
This pull request contains changes to improve clarity, correctness and structure.
Description correction:
Corrected writtenin to written in
Corrected maintianed to maintained
Corrected reponsibility to responsibility
Please review the changes and let me know if any additional changes are needed.