-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify values in secondary database against expected state #13281
Closed
archang19
wants to merge
10
commits into
facebook:main
from
archang19:secondary-value-pre-post-range
+157
−23
Closed
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cd34caf
Use pre/post read expected value to check secondary
archang19 cce848a
use all threads to verify different portions
archang19 14f143a
Rename cmp_db and cmp_cfhs
archang19 3cc59d5
Update comments and abort error messaging
archang19 73da410
update comment and error message
archang19 e6076bc
Add an option for test_secondary to the simple default params
archang19 eb08ed2
Incorporate secondary testing as part of regular get() tests
archang19 0e9f00d
Do not run continuous verification interval unless we explicitly set …
archang19 dd5be01
Fix lint warning
archang19 f1aa17a
Update comment
archang19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix lint warning
commit dd5be01d56ce2854f734cf2c2bc6ace645fbe7ea
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was to get our internal code linter to stop complaining about the vector index access