Support disallow_memtable_writes for default CF #13513
Open
+44
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: in follow-up to facebook#13489 and facebook#13431 Because this feature is relatively simple and of the "protecting users from themselves" variety, I think we can call it production-ready. Release note added (none last time). Test Plan: unit tests updated
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
anand1976
reviewed
Apr 3, 2025
There was a problem hiding this comment.
Generally LGTM. But isn't it fairly easy to flag a WriteBatch with writes to the default CF in WriteBatchInternal::GetColumnFamilyIdAndTimestampSize(), and lazily reject it before attempting to insert into the memtable and triggering the error handling behavior?
|
It looks like I was too eager to avoid an "extra" check that we're mostly paying for already. I'll modify it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: in follow-up to #13489 and #13431
Because this feature is relatively simple and of the "protecting users from themselves" variety, I think we can call it production-ready. Release note added (none last time).
Test Plan: unit tests updated