Avoid corruption when RepairDB is used on db where there are blob files. #14175
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If https://github.com/facebook/rocksdb/wiki/BlobDB could also be updated to mention that RepairDB and the ldb repair command do not work with BlobDB then it could help avoid corruption. facebook#13884
facebook#13884 It would also be good to mention this on https://github.com/facebook/rocksdb/wiki/RocksDB-Repairer
All existing RocksDB tests pass and the reproducer of corruption from facebook#13884 no longer happens. > ./ldb repair --db=/tmp/blob_repair_test Failed: Not implemented: RepairDB does not support blob files, found blob file: 000009.blob
early with Status::NotSupported if blob files are present.
and the db is not corrupt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Status::NotSupported is returned.
#13884
#13090