Add Java API support for WaitForCompactOptions#14274
Open
mike-evolved wants to merge 4 commits intofacebook:mainfrom
Open
Add Java API support for WaitForCompactOptions#14274mike-evolved wants to merge 4 commits intofacebook:mainfrom
mike-evolved wants to merge 4 commits intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Java bindings for the
WaitForCompactOptionsAPI, bringing the Java API to feature parity with the C++ API.What Changed
Added
WaitForCompactOptionsclass with all 5 options from C++ API:abortOnPause- abort waiting if compaction pausesflush- trigger flush before waitingwaitForPurge- wait for purge to completecloseDb- close database after waitingtimeout- maximum time to wait (microseconds)Added
RocksDB.waitForCompact()method to use these optionsImplemented JNI bridge between Java and C++
Testing