Add C API and Java bindings for IngestExternalFileOptions::link_files#14298
Open
corydolphin wants to merge 2 commits intofacebook:mainfrom
Open
Add C API and Java bindings for IngestExternalFileOptions::link_files#14298corydolphin wants to merge 2 commits intofacebook:mainfrom
corydolphin wants to merge 2 commits intofacebook:mainfrom
Conversation
Add rocksdb_ingestexternalfileoptions_set_link_files() to expose the link_files option that was added in PR facebook#12980 but was missing from the C API. This allows C/Rust bindings to use hard linking for SST file ingestion.
Add linkFiles() and setLinkFiles() methods to the Java API to expose the link_files option for hard linking SST files during ingestion.
corydolphin
force-pushed
the
claude/add-hard-linking-support-XP8I8
branch
from
b7cf5f0 to
9ec4a2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the existing link_files option in IngestExternalFileOptions to the C API and Java (JNI) bindings.
I am working on a project which could benefit from using hard-link based ingestion to simplify managing a content-addressable store of read-only SSTFiles. Hopefully this can benefit others as well :-)
This is my first time contributing to rocksdb, so please let me know if there is anything else I can do to help make this change easy to merge. I've attempted to follow the patterns for tests closely, but may have missed something.
I have signed the CLA.