Skip to content

db_crashtest: re-enable track_and_verify_wals with disabled fault injection (#14860) #14860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hx235 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

db_crashtest: re-enable track_and_verify_wals with disabled fault injection (#14860) #14860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions tools/db_crashtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,7 @@ def apply_random_seed_per_iteration():
"memtable_verify_per_key_checksum_on_seek": lambda: random.choice([0] * 7 + [1]),
"memtable_batch_lookup_optimization": lambda: random.randint(0, 1),
"allow_unprepared_value": lambda: random.choice([0, 1]),
# TODO(hx235): enable `track_and_verify_wals` after stabalizing the stress test
"track_and_verify_wals": lambda: random.choice([0]),
"track_and_verify_wals": lambda: random.choice([0, 1]),
"remote_compaction_worker_threads": lambda: random.choice([0, 8]),
"allow_resumption_one_in": lambda: random.choice([0, 1, 2, 20]),
# TODO(jaykorean): Change to lambda: random.choice([0, 1]) after addressing all remote compaction failures
Expand Down Expand Up @@ -1571,6 +1570,22 @@ def finalize_and_sanitize(src_params):
dest_params["clear_column_family_one_in"] = 0
dest_params["test_multi_ops_txns"] = 0

if dest_params.get("track_and_verify_wals", 0) == 1:
# Disable fault injection while track_and_verify_wals is on. These fault
# injections trigger auto recovery, which flushes the memtable and
# rotates the WAL; that is currently incompatible with WAL tracking and
# verification and surfaces as spurious WAL verification failures.
# TODO: re-enable once the auto-recovery vs. track_and_verify_wals
# compatibility issue is fixed.
dest_params["write_fault_one_in"] = 0
dest_params["metadata_write_fault_one_in"] = 0
dest_params["read_fault_one_in"] = 0
dest_params["metadata_read_fault_one_in"] = 0
dest_params["open_metadata_write_fault_one_in"] = 0
dest_params["open_metadata_read_fault_one_in"] = 0
dest_params["open_write_fault_one_in"] = 0
dest_params["open_read_fault_one_in"] = 0

return dest_params


Expand Down
Loading