Skip to content

Cache GetKeysEndOffset in BlockIter to speed up Next inner loop #14917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meta-codesync wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

Cache GetKeysEndOffset in BlockIter to speed up Next inner loop #14917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions table/block_based/block.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,9 @@ class BlockIter : public InternalIteratorBase<TValue> {
uint32_t restarts_; // Offset of restart array (list of fixed32)
// current_ is offset in data_ of current entry. >= restarts_ if !Valid
uint32_t current_;
// Cached result of GetKeysEndOffset(). Computed once in InitializeBase()
// since values_section_, data_, and restarts_ do not change afterward.
uint32_t keys_end_offset_{0};
// Raw key from block.
IterKey raw_key_;
// Buffer for key data when global seqno assignment is enabled.
Expand Down Expand Up @@ -588,6 +591,9 @@ class BlockIter : public InternalIteratorBase<TValue> {
(block_restart_interval > 0 || num_restarts == 1)));

values_section_ = values_section;
keys_end_offset_ = values_section_
? static_cast<uint32_t>(values_section_ - data_)
: restarts_;
current_ = GetKeysEndOffset();
}

Expand Down Expand Up @@ -704,10 +710,7 @@ class BlockIter : public InternalIteratorBase<TValue> {
// Return the offset where the keys section ends.
// For separated KV storage, this is the start of the values section.
// Otherwise, it's the start of the restart array.
inline uint32_t GetKeysEndOffset() const {
return values_section_ ? static_cast<uint32_t>(values_section_ - data_)
: restarts_;
}
inline uint32_t GetKeysEndOffset() const { return keys_end_offset_; }

uint32_t GetRestartPoint(uint32_t index) const {
assert(index < num_restarts_);
Expand Down
Loading