Fix native ReadOptions leak in RocksDB.close() (Java) - #15069
Open
taimoor789 wants to merge 1 commit into
Open
Conversation
RocksDB.close() disposed owned column family handles and its own native handle, but never released defaultReadOptions_, leaking one native ReadOptions object per opened DB instance for the life of the JVM. Fixes facebook#15036.
mjsax
reviewed
Aug 13, 2026
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Thanks for providing a fix! -- I am not a RocksDB maintainer, but seems to be straightforward. LGTM.
Hope this can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RocksDB.close()disposes owned column family handles and its own native handle, but never releasesdefaultReadOptions_, theReadOptionsobject eagerly created in the field declaration and used internally bynewIterator(). This leaks one nativeReadOptionsobject per openedRocksDBinstance for the lifetime of the JVM, since there is no finalizer orCleanerfallback anywhere in theRocksObjecthierarchy, an explicitclose()call is the only path to native cleanup, and this one was never wired up.Fix
Added
defaultReadOptions_.close()insideclose()'s existing cleanup block, alongsidedisposeInternal().Testing
Added
closeReleasesDefaultReadOptionstoRocksDBTest.java, assertingdefaultReadOptions_.isOwningHandle()transitions fromtruetofalseacross aclose()call. Full Java suite passes (1241 tests, 0 failures).Fixes #15036