Add rocksdb_iter_is_key_pinned and rocksdb_iter_is_value_pinned to C API - #15109
Add rocksdb_iter_is_key_pinned and rocksdb_iter_is_value_pinned to C API#15109sachinsharma3191 wants to merge 1 commit into
Conversation
Expose Iterator::IsKeyPinned() and IsValuePinned() through the C API so that C and FFI consumers can check whether an iterator's key or value buffer is pinned (stable across iterator movements with pin_data). Closes facebook#14903
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
rocksdb_iter_is_key_pinned(const rocksdb_iterator_t*)rocksdb_iter_is_value_pinned(const rocksdb_iterator_t*)Iterator::GetPropertymechanism withrocksdb.iterator.is-key-pinned/rocksdb.iterator.is-value-pinneddb/c_test.cexercising both with and withoutpin_dataTest plan
c_testpasses with the newiter_pinnedtest phasepin_data=trueand exercises the functions withoutpin_datato ensure no crashesunsigned char,constiterator parameter)Closes #14903