Skip to content

Add ARM ConcurrentCompaction repro coverage and stabilize crash tests - #15124

Open
xingbowang wants to merge 6 commits into
facebook:mainfrom
xingbowang:2026_08_18_arm_concurrent_compaction_repro
Open

Add ARM ConcurrentCompaction repro coverage and stabilize crash tests#15124
xingbowang wants to merge 6 commits into
facebook:mainfrom
xingbowang:2026_08_18_arm_concurrent_compaction_repro

Conversation

@xingbowang

Copy link
Copy Markdown
Contributor

Summary

  • Add a temporary ARM64 GitHub Actions job that isolates CompactionServiceTest.ConcurrentCompaction, exercises normal and coerced-context-switch builds under serial and high-contention runs, and uploads repro artifacts.
  • Stabilize the concurrent compaction test by capturing each input filename by value, and preserve direct OpenAndCompact setup failures in the serialized compaction-service result for better diagnostics.
  • Select track_and_verify_wals once per crash-test run, keep WAL enabled when verification is selected, disable verification for best-efforts recovery, and cover the sanitization behavior with unit tests.

Test plan

  • python3 -m unittest tools.db_crashtest_test
  • ./compaction_service_test --gtest_filter=CompactionServiceTest.ConcurrentCompaction --gtest_repeat=20
  • git diff --check upstream/main...2026_08_18_arm_concurrent_compaction_repro

make check-workflow-yaml was not run successfully because Ruby is not installed in the local environment. The ARM-specific reproduction matrix is exercised by the new GitHub Actions job.

@meta-cla meta-cla Bot added the CLA Signed label Aug 18, 2026
…urrent_compaction_repro

# Conflicts:
#	db/compaction/compaction_service_test.cc
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

✅ clang-tidy: No findings on changed lines

Completed in 314.3s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants