build a single binary to run all microbenches #9421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff adds a cpp_binary target to internal_repo_rocksdb (via buckifier) and the equivalent to make. The following command will run the microbenchmarks: ``` buck2 run //internal_repo_rocksdb/repo:rocksdb_microbench_bin ``` ASAN detects an issue with the microbenchmarks, but I suspect the root cause is google/benchmark#1322. Differential Revision: D33709046 fbshipit-source-id: 5a94b478e1a294eea7f3f95c45a89636b40cc789
|
This pull request was exported from Phabricator. Differential Revision: D33709046 |
jay-zhuang
reviewed
Jan 25, 2022
Comment on lines
+11
to
+12
| #include "microbench/db_basic_bench.cc" | ||
| #include "microbench/ribbon_bench.cc" |
There was a problem hiding this comment.
I think it could be a problem as we adding more benchmark files, like name conflict, especially because each benchmark code includes its own header files.
Questions:
- do we have to have single benchmark binary?
- can we replace it with a script which calls other binaries?
There was a problem hiding this comment.
do we have to have single benchmark binary?
I don't think so.
can we replace it with a script which calls other binaries?
I don't think so.
I'm fairly confident I can get this to work well while having each benchmark file be a separate binary (provided each benchmark has a binary_cpp target), so I'll try this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
build a single binary to run all microbenches
ASAN detects an issue with the microbenchmarks, but I suspect the root cause is google/benchmark#1322.
Differential Revision: D33709046