Skip to content

Commit

Permalink
Fix wording of goto off warm warning
Browse files Browse the repository at this point in the history
Summary: Wording of this warning was confusing before. Changing it to better reflect what it's warning users from (warning about using Goto rather than rebasing)

Reviewed By: evangrayk

Differential Revision: D68338444

fbshipit-source-id: a44ed1bf2ac40b1dd1fc81c8fd07c52bb10f4ec8
  • Loading branch information
Andy Li authored and facebook-github-bot committed Jan 17, 2025
1 parent 07a63cd commit 7ecf580
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions addons/isl/src/Commit.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -727,11 +727,11 @@ async function maybeWarnAboutRebaseOffWarm(dest: CommitInfo): Promise<boolean> {
);
if (await warning) {
tracker.track('WarnAboutRebaseOffWarm');
const buttons = [t('Opt Out of Future Warnings'), t('Cancel'), t('Rebase Anyway')];
const buttons = [t('Opt Out of Future Warnings'), t('Cancel'), t('Goto Anyway')];
const answer = await showModal({
type: 'confirm',
buttons,
title: <T>Rebase off Warm Commit</T>,
title: <T>Move off Warm Commit</T>,
message: t(
Internal.warnAboutRebaseOffWarmReason ??
"The commit you're on is a warmed up commit. Moving off will cause slower builds and performance.\n" +
Expand Down

0 comments on commit 7ecf580

Please sign in to comment.