streampager: upgrade dependencies #1008

martinvonz · 2025-01-14T06:09:54Z

Many of streampager's dependencies were very old. The dirs version, for example was 5 years old. It seems it's about time to to upgrade.

facebook-github-bot · 2025-01-14T06:09:59Z

Hi @martinvonz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

martinvonz · 2025-01-14T17:16:54Z

I'm trying to go through the Google-internal process to get approval to sign the CLA.

Many of streampager's dependencies were very old. The `dirs` version, for example was 5 years old. It seems it's about time to to upgrade.

facebook-github-bot · 2025-02-07T17:53:28Z

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

martinvonz · 2025-02-07T17:54:41Z

I've finally gotten the CLA signed, so this is ready for review now. Thanks

quark-zju · 2025-02-11T19:36:49Z

Sorry for taking long. Running tests in the monorepo takes a long time. Some dependencies cannot be upgraded right now:

unicode-width: blocked by Cell width incorrect when using external formatting phsym/prettytable-rs#165. Ideally prettytable-rs should pin unicode-width itself so the global unicode-width can be upgraded.
bit-set: upgrade caused hhvm to fail compile.
memmap2: upgrade caused a hhvm test to segfault ("address not mapped to object").
notify: 8.0 does not compile on macos - it uses fsevents_sys::FSEventsGetCurrentEventId introduced by fsevents-sys 4.1.0 but notify's Cargo.toml specifies fsevents-sys = "4.0.0".
lru, indexmap: upgrade introduces hashbrown 0.15.2 which does not compile with "nightly" feature turned on, because it uses the strict_provenance_lints feature introduced by Rust 1.84 (Jan 8). We can retry after the internal Rust team upgrade the compiler.

I'll upgrade the rest once tests pass and publish a new release.

ilyagr · 2025-02-11T21:32:07Z

Is termux difficult to update? TODO: Link to the relevant thread about NetBSD.

Update: I guess not, since you were listing exceptions.

quark-zju · 2025-02-11T21:42:44Z

termwiz 0.23 upgrade is not in this change but I can try to get it included.

quark-zju · 2025-02-12T22:09:33Z

Actually, upgrading terminal related crates (terminfo, termwiz, rattui) caused a lot of breakages. I'll try to upgrade them in a separate change.

Summary: Upgrade dependencies requested by facebook/sapling#1008, with the exceptions: - No change to `lru` and `indexmap`, because they want `hashbrown 0.15.2`, which fails to compile until Rust [1.84](rust-lang/rust@56ee492). ``` error[E0635]: unknown feature `strict_provenance_lints` --> third-party/rust/vendor/hashbrown-0.15.2/src/lib.rs:24:9 | 24 | strict_provenance_lints | ^^^^^^^^^^^^^^^^^^^^^^^ ``` - No change to `notify`. It specifies `fsevents-sys = "4.0.0"` and fails to compile: ``` error[E0425]: cannot find function, tuple struct or tuple variant `FSEventsGetCurrentEventId` in crate `fs` --> third-party/rust/vendor/notify-8.0.0/src/fsevent.rs:462:40 | 462 | let event_id = fs::FSEventsGetCurrentEventId(); | ^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `fs` (`FSEventsGetCurrentEventId` was introduced in `fsevents-sys 4.1.0`) ``` - No change to `unicode-width` because phsym/prettytable-rs#165 (`prettytable-rs` does not pin the "good" version of `unicode-width` so `unicode-width` has to be globally pinned) - No change to `bit-set` to avoid incompatible types: ``` error[E0308]: mismatched types --> fbcode/hphp/hack/src/hackc/emitter/opt_body.rs:287:49 | 287 | avl_in.union_with(&BitSet::from_bit_vec(BitVec::from_elem(nparams, true))); | -------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `bit_vec::BitVec`, found `BitVec` | | | arguments to this function are incorrect | = note: `BitVec` and `bit_vec::BitVec` have similar names, but are actually distinct types note: `BitVec` is defined in crate `bit_vec` --> third-party/rust/vendor/bit-vec-0.6.2/src/lib.rs:210:1 note: `bit_vec::BitVec` is defined in crate `bit_vec` --> third-party/rust/vendor/bit-vec-0.8.0/src/lib.rs:249:1 = note: perhaps two different versions of crate `bit_vec` are being used? note: associated function defined here --> third-party/rust/vendor/bit-set-0.8.0/src/lib.rs:240:12 ``` - No change to `memmap2` since it seems to cause hack-www-test breakage. Reviewed By: zzl0 Differential Revision: D69427081 fbshipit-source-id: f520721fd4b828ae46c6b2d7875fa68eaafe603e

Summary: Upgrade dependencies requested by #1008, with the exceptions: - No change to `lru` and `indexmap`, because they want `hashbrown 0.15.2`, which fails to compile until Rust [1.84](rust-lang/rust@56ee492). ``` error[E0635]: unknown feature `strict_provenance_lints` --> third-party/rust/vendor/hashbrown-0.15.2/src/lib.rs:24:9 | 24 | strict_provenance_lints | ^^^^^^^^^^^^^^^^^^^^^^^ ``` - No change to `notify`. It specifies `fsevents-sys = "4.0.0"` and fails to compile: ``` error[E0425]: cannot find function, tuple struct or tuple variant `FSEventsGetCurrentEventId` in crate `fs` --> third-party/rust/vendor/notify-8.0.0/src/fsevent.rs:462:40 | 462 | let event_id = fs::FSEventsGetCurrentEventId(); | ^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `fs` (`FSEventsGetCurrentEventId` was introduced in `fsevents-sys 4.1.0`) ``` - No change to `unicode-width` because phsym/prettytable-rs#165 (`prettytable-rs` does not pin the "good" version of `unicode-width` so `unicode-width` has to be globally pinned) - No change to `bit-set` to avoid incompatible types: ``` error[E0308]: mismatched types --> fbcode/hphp/hack/src/hackc/emitter/opt_body.rs:287:49 | 287 | avl_in.union_with(&BitSet::from_bit_vec(BitVec::from_elem(nparams, true))); | -------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `bit_vec::BitVec`, found `BitVec` | | | arguments to this function are incorrect | = note: `BitVec` and `bit_vec::BitVec` have similar names, but are actually distinct types note: `BitVec` is defined in crate `bit_vec` --> third-party/rust/vendor/bit-vec-0.6.2/src/lib.rs:210:1 note: `bit_vec::BitVec` is defined in crate `bit_vec` --> third-party/rust/vendor/bit-vec-0.8.0/src/lib.rs:249:1 = note: perhaps two different versions of crate `bit_vec` are being used? note: associated function defined here --> third-party/rust/vendor/bit-set-0.8.0/src/lib.rs:240:12 ``` - No change to `memmap2` since it seems to cause hack-www-test breakage. Reviewed By: zzl0 Differential Revision: D69427081 fbshipit-source-id: f520721fd4b828ae46c6b2d7875fa68eaafe603e

Summary: Upgrade dependencies requested by facebook/sapling#1008, with the exceptions: - No change to `lru` and `indexmap`, because they want `hashbrown 0.15.2`, which fails to compile until Rust [1.84](rust-lang/rust@56ee492). ``` error[E0635]: unknown feature `strict_provenance_lints` --> third-party/rust/vendor/hashbrown-0.15.2/src/lib.rs:24:9 | 24 | strict_provenance_lints | ^^^^^^^^^^^^^^^^^^^^^^^ ``` - No change to `notify`. It specifies `fsevents-sys = "4.0.0"` and fails to compile: ``` error[E0425]: cannot find function, tuple struct or tuple variant `FSEventsGetCurrentEventId` in crate `fs` --> third-party/rust/vendor/notify-8.0.0/src/fsevent.rs:462:40 | 462 | let event_id = fs::FSEventsGetCurrentEventId(); | ^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `fs` (`FSEventsGetCurrentEventId` was introduced in `fsevents-sys 4.1.0`) ``` - No change to `unicode-width` because phsym/prettytable-rs#165 (`prettytable-rs` does not pin the "good" version of `unicode-width` so `unicode-width` has to be globally pinned) - No change to `bit-set` to avoid incompatible types: ``` error[E0308]: mismatched types --> fbcode/hphp/hack/src/hackc/emitter/opt_body.rs:287:49 | 287 | avl_in.union_with(&BitSet::from_bit_vec(BitVec::from_elem(nparams, true))); | -------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `bit_vec::BitVec`, found `BitVec` | | | arguments to this function are incorrect | = note: `BitVec` and `bit_vec::BitVec` have similar names, but are actually distinct types note: `BitVec` is defined in crate `bit_vec` --> third-party/rust/vendor/bit-vec-0.6.2/src/lib.rs:210:1 note: `bit_vec::BitVec` is defined in crate `bit_vec` --> third-party/rust/vendor/bit-vec-0.8.0/src/lib.rs:249:1 = note: perhaps two different versions of crate `bit_vec` are being used? note: associated function defined here --> third-party/rust/vendor/bit-set-0.8.0/src/lib.rs:240:12 ``` - No change to `memmap2` since it seems to cause hack-www-test breakage. Reviewed By: zzl0 Differential Revision: D69427081 fbshipit-source-id: f520721fd4b828ae46c6b2d7875fa68eaafe603e

Summary: Upgrade dependencies requested by facebook/sapling#1008, with the exceptions: - No change to `lru` and `indexmap`, because they want `hashbrown 0.15.2`, which fails to compile until Rust [1.84](rust-lang/rust@56ee492). ``` error[E0635]: unknown feature `strict_provenance_lints` --> third-party/rust/vendor/hashbrown-0.15.2/src/lib.rs:24:9 | 24 | strict_provenance_lints | ^^^^^^^^^^^^^^^^^^^^^^^ ``` - No change to `notify`. It specifies `fsevents-sys = "4.0.0"` and fails to compile: ``` error[E0425]: cannot find function, tuple struct or tuple variant `FSEventsGetCurrentEventId` in crate `fs` --> third-party/rust/vendor/notify-8.0.0/src/fsevent.rs:462:40 | 462 | let event_id = fs::FSEventsGetCurrentEventId(); | ^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `fs` (`FSEventsGetCurrentEventId` was introduced in `fsevents-sys 4.1.0`) ``` - No change to `unicode-width` because phsym/prettytable-rs#165 (`prettytable-rs` does not pin the "good" version of `unicode-width` so `unicode-width` has to be globally pinned) - No change to `bit-set` to avoid incompatible types: ``` error[E0308]: mismatched types --> fbcode/hphp/hack/src/hackc/emitter/opt_body.rs:287:49 | 287 | avl_in.union_with(&BitSet::from_bit_vec(BitVec::from_elem(nparams, true))); | -------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `bit_vec::BitVec`, found `BitVec` | | | arguments to this function are incorrect | = note: `BitVec` and `bit_vec::BitVec` have similar names, but are actually distinct types note: `BitVec` is defined in crate `bit_vec` --> third-party/rust/vendor/bit-vec-0.6.2/src/lib.rs:210:1 note: `bit_vec::BitVec` is defined in crate `bit_vec` --> third-party/rust/vendor/bit-vec-0.8.0/src/lib.rs:249:1 = note: perhaps two different versions of crate `bit_vec` are being used? note: associated function defined here --> third-party/rust/vendor/bit-set-0.8.0/src/lib.rs:240:12 ``` - No change to `memmap2` since it seems to cause hack-www-test breakage. Test Plan: Follow https://www.internalfb.com/wiki/Rust/Third_Party_Libraries/Adding_or_Updating_Libraries/#adding-or-updating-crate ``` quark@devvm15458 ~/fbsource/third-party/rust % ~/fbsource/fbcode/common/rust/tools/scripts/third-party-check.sh ... BUILD SUCCEEDED ~/fbsource/fbcode/common/rust/tools/scripts/third-party-check.sh 18.58s user 5.79s system 1% cpu 21:10.02 total ``` Use a modified [`fbcode/common/rust/tools/scripts/check_all.sh`](https://www.internalfb.com/code/fbsource/[d9bbdb2c9ba5d475bb8d027b6acbb4f648fcf269]/fbcode/common/rust/tools/scripts/check_all.sh) to reduce the oomd kill risk. Run from fbcode ondemand. Output: P1730344880 There is a pre-existing issue that repros on master: ``` error[E0308]: mismatched types --> fbcode/reliable_volumes/director/main.rs:125:20 | 125 | Arc::clone(&oncall3_client), | ---------- ^^^^^^^^^^^^^^^ expected trait `OncallService`, found trait `Oncall3Service` | | | arguments to this function are incorrect ``` Most (31 of 32) builds passed cleanly. The last one failed with ``` error: Error running analysis for `fbcode//buck2/tests/targets/rules/cxx/duplicated_symbols_link_groups:rust_exports_dep_bin (ovr_config//platform/linux:x86_64-fbcode-platform010-clang15-split-dwarf-si ngle#3306cf598294f8e8)` --> fbcode/common/rust/tools/scripts/check_all.bxl:32:21 | 32 | for k, value in ctx.build(check_sub_targets, materializations = "skip").items(): | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | Caused by: Traceback (most recent call last): File <builtin>, in <module> * fbcode/buck2/prelude/rust/rust_binary.bzl:405, in rust_binary_impl providers, args = _rust_binary_common( * fbcode/buck2/prelude/rust/rust_binary.bzl:137, in _rust_binary_common rust_cxx_link_group_info = inherited_rust_cxx_link_group_info( * fbcode/buck2/prelude/rust/link_info.bzl:498, in inherited_rust_cxx_link_group_info labels_to_links = get_filtered_labels_to_links_map( * fbcode/buck2/prelude/cxx/link_groups.bzl:574, in get_filtered_labels_to_links_map add_link_group(target, target_link_group) * fbcode/buck2/prelude/cxx/link_groups.bzl:498, in add_link_group fail("'{}' artifact included multiple times into '{}' link group. From '{}:{}... error: fail: '<source buck2/tests/targets/rules/cxx/duplicated_symbols_link_groups/dep.c>' artifact included multiple times into 'all_deps' link group. From 'buck2/tests/targets/rules/cxx/duplicate d_symbols_link_groups:dep' and 'buck2/tests/targets/rules/cxx/duplicated_symbols_link_groups:exports_dep' --> fbcode/buck2/prelude/cxx/link_groups.bzl:498:21 | 498 | fail("'{}' artifact included multiple times into '{}' link group. From '{}:{}' and '{}:{}'".format(src, target_group, target.package, target.name, previous_target.package, previous_target.name)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ | ``` which seems to be a buck definition issue. Reviewed By: zzl0 Differential Revision: D69427081 fbshipit-source-id: f520721fd4b828ae46c6b2d7875fa68eaafe603e

Summary: Upgrade dependencies requested by facebook/sapling#1008, with the exceptions: - No change to `lru` and `indexmap`, because they want `hashbrown 0.15.2`, which fails to compile until Rust [1.84](rust-lang/rust@56ee492). ``` error[E0635]: unknown feature `strict_provenance_lints` --> third-party/rust/vendor/hashbrown-0.15.2/src/lib.rs:24:9 | 24 | strict_provenance_lints | ^^^^^^^^^^^^^^^^^^^^^^^ ``` - No change to `notify`. It specifies `fsevents-sys = "4.0.0"` and fails to compile: ``` error[E0425]: cannot find function, tuple struct or tuple variant `FSEventsGetCurrentEventId` in crate `fs` --> third-party/rust/vendor/notify-8.0.0/src/fsevent.rs:462:40 | 462 | let event_id = fs::FSEventsGetCurrentEventId(); | ^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `fs` (`FSEventsGetCurrentEventId` was introduced in `fsevents-sys 4.1.0`) ``` - No change to `unicode-width` because phsym/prettytable-rs#165 (`prettytable-rs` does not pin the "good" version of `unicode-width` so `unicode-width` has to be globally pinned) - No change to `bit-set` to avoid incompatible types: ``` error[E0308]: mismatched types --> fbcode/hphp/hack/src/hackc/emitter/opt_body.rs:287:49 | 287 | avl_in.union_with(&BitSet::from_bit_vec(BitVec::from_elem(nparams, true))); | -------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `bit_vec::BitVec`, found `BitVec` | | | arguments to this function are incorrect | = note: `BitVec` and `bit_vec::BitVec` have similar names, but are actually distinct types note: `BitVec` is defined in crate `bit_vec` --> third-party/rust/vendor/bit-vec-0.6.2/src/lib.rs:210:1 note: `bit_vec::BitVec` is defined in crate `bit_vec` --> third-party/rust/vendor/bit-vec-0.8.0/src/lib.rs:249:1 = note: perhaps two different versions of crate `bit_vec` are being used? note: associated function defined here --> third-party/rust/vendor/bit-set-0.8.0/src/lib.rs:240:12 ``` - No change to `memmap2` since it seems to cause hack-www-test breakage. Reviewed By: zzl0 Differential Revision: D69427081 fbshipit-source-id: f520721fd4b828ae46c6b2d7875fa68eaafe603e

quark-zju · 2025-02-14T22:22:40Z

I published a new version of streampager that includes the termwiz upgrade.

Summary: Upgrade dependencies requested by facebook/sapling#1008, with the exceptions: - No change to `lru` and `indexmap`, because they want `hashbrown 0.15.2`, which fails to compile until Rust [1.84](rust-lang/rust@56ee492). ``` error[E0635]: unknown feature `strict_provenance_lints` --> third-party/rust/vendor/hashbrown-0.15.2/src/lib.rs:24:9 | 24 | strict_provenance_lints | ^^^^^^^^^^^^^^^^^^^^^^^ ``` - No change to `notify`. It specifies `fsevents-sys = "4.0.0"` and fails to compile: ``` error[E0425]: cannot find function, tuple struct or tuple variant `FSEventsGetCurrentEventId` in crate `fs` --> third-party/rust/vendor/notify-8.0.0/src/fsevent.rs:462:40 | 462 | let event_id = fs::FSEventsGetCurrentEventId(); | ^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `fs` (`FSEventsGetCurrentEventId` was introduced in `fsevents-sys 4.1.0`) ``` - No change to `unicode-width` because phsym/prettytable-rs#165 (`prettytable-rs` does not pin the "good" version of `unicode-width` so `unicode-width` has to be globally pinned) - No change to `bit-set` to avoid incompatible types: ``` error[E0308]: mismatched types --> fbcode/hphp/hack/src/hackc/emitter/opt_body.rs:287:49 | 287 | avl_in.union_with(&BitSet::from_bit_vec(BitVec::from_elem(nparams, true))); | -------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `bit_vec::BitVec`, found `BitVec` | | | arguments to this function are incorrect | = note: `BitVec` and `bit_vec::BitVec` have similar names, but are actually distinct types note: `BitVec` is defined in crate `bit_vec` --> third-party/rust/vendor/bit-vec-0.6.2/src/lib.rs:210:1 note: `bit_vec::BitVec` is defined in crate `bit_vec` --> third-party/rust/vendor/bit-vec-0.8.0/src/lib.rs:249:1 = note: perhaps two different versions of crate `bit_vec` are being used? note: associated function defined here --> third-party/rust/vendor/bit-set-0.8.0/src/lib.rs:240:12 ``` - No change to `memmap2` since it seems to cause hack-www-test breakage. Reviewed By: zzl0 Differential Revision: D69427081 fbshipit-source-id: f520721fd4b828ae46c6b2d7875fa68eaafe603e

streampager: upgrade dependencies

d32a285

Many of streampager's dependencies were very old. The `dirs` version, for example was 5 years old. It seems it's about time to to upgrade.

martinvonz force-pushed the push-rtnwkwywpoty branch from 80adfec to d32a285 Compare February 7, 2025 17:53

facebook-github-bot added the CLA Signed label Feb 7, 2025

martinvonz closed this Feb 10, 2025

martinvonz deleted the push-rtnwkwywpoty branch February 10, 2025 00:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

streampager: upgrade dependencies #1008

streampager: upgrade dependencies #1008

martinvonz commented Jan 14, 2025

facebook-github-bot commented Jan 14, 2025

martinvonz commented Jan 14, 2025 •

edited

Loading

facebook-github-bot commented Feb 7, 2025

martinvonz commented Feb 7, 2025

quark-zju commented Feb 11, 2025

ilyagr commented Feb 11, 2025 •

edited

Loading

quark-zju commented Feb 11, 2025

quark-zju commented Feb 12, 2025

quark-zju commented Feb 14, 2025

streampager: upgrade dependencies #1008

streampager: upgrade dependencies #1008

Conversation

martinvonz commented Jan 14, 2025

facebook-github-bot commented Jan 14, 2025

Action Required

Process

martinvonz commented Jan 14, 2025 • edited Loading

facebook-github-bot commented Feb 7, 2025

martinvonz commented Feb 7, 2025

quark-zju commented Feb 11, 2025

ilyagr commented Feb 11, 2025 • edited Loading

quark-zju commented Feb 11, 2025

quark-zju commented Feb 12, 2025

quark-zju commented Feb 14, 2025

martinvonz commented Jan 14, 2025 •

edited

Loading

ilyagr commented Feb 11, 2025 •

edited

Loading