Skip to content

[stylex] improve treeshakability #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henryqdineen wants to merge 1 commit into
base: main
Choose a base branch
from
+42 −22
Open

[stylex] improve treeshakability #1368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/@stylexjs/stylex/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,6 @@
},
"files": [
"lib/*"
]
],
"sideEffects": false
}
18 changes: 18 additions & 0 deletions packages/@stylexjs/stylex/rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,24 @@ const config = {
babelHelpers: 'bundled',
configFile: path.resolve(__dirname, '.babelrc.js'),
}),
{
name: 'legacy-merge-export-pure',
transform(code, id) {
if (id === path.resolve(__dirname, 'src/stylex.js')) {
const newCode = code.replace(
'export const legacyMerge =',
'export const legacyMerge = /*@__PURE__*/',
);
if (newCode === code) {
throw new Error(
'Expect to find to "export const legacyMerge =" in src/stylex.js',
);
}
return newCode;
}
return code;
},
},
resolve(),
commonjs(),
],
Expand Down
43 changes: 22 additions & 21 deletions packages/@stylexjs/stylex/src/stylex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,25 +262,26 @@ type IStyleX = {
...
};

function _legacyMerge(
...styles: $ReadOnlyArray<StyleXArray<?CompiledStyles | boolean>>
): string {
const [className] = styleq(styles);
return className;
}

_legacyMerge.create = create;
_legacyMerge.createTheme = createTheme;
_legacyMerge.defineConsts = defineConsts;
_legacyMerge.defineMarker = defineMarker;
_legacyMerge.defineVars = defineVars;
_legacyMerge.defaultMarker = defaultMarker;
_legacyMerge.firstThatWorks = firstThatWorks;
_legacyMerge.keyframes = keyframes;
_legacyMerge.positionTry = positionTry;
_legacyMerge.props = props;
_legacyMerge.types = types;
_legacyMerge.when = when;
_legacyMerge.viewTransitionClass = viewTransitionClass;
export const legacyMerge: IStyleX = /*@__PURE__*/ (function () {
function _legacyMerge(
...styles: $ReadOnlyArray<StyleXArray<?CompiledStyles | boolean>>
): string {
const [className] = styleq(styles);
return className;
}

export const legacyMerge: IStyleX = _legacyMerge;
_legacyMerge.create = create;
_legacyMerge.createTheme = createTheme;
_legacyMerge.defineConsts = defineConsts;
_legacyMerge.defineMarker = defineMarker;
_legacyMerge.defineVars = defineVars;
_legacyMerge.defaultMarker = defaultMarker;
_legacyMerge.firstThatWorks = firstThatWorks;
_legacyMerge.keyframes = keyframes;
_legacyMerge.positionTry = positionTry;
_legacyMerge.props = props;
_legacyMerge.types = types;
_legacyMerge.when = when;
_legacyMerge.viewTransitionClass = viewTransitionClass;
return _legacyMerge;
})();