Skip to content

Conversation

@ynamkit13
Copy link

What changed / motivation ?

Updated the sortedRules function to improve the sorting logic for media queries.
Media queries with max-width are now sorted from smallest to largest values.
Media queries with min-width are now sorted from largest to smallest values.
Added logic to ensure max-width queries are prioritized over min-width queries when both are present.
Fallback to alphanumeric sorting remains for non-media query rules.

Linked PR/Issues

Fixes #1407

Additional Context

All tests passed

Pre-flight checklist

@vercel
Copy link

vercel bot commented Jan 3, 2026

@ynamkit13 is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@meta-cla
Copy link

meta-cla bot commented Jan 3, 2026

Hi @ynamkit13!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2026
@meta-cla
Copy link

meta-cla bot commented Jan 3, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] Better media query sorting

1 participant