Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'apps' to 'examples' #950

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Rename 'apps' to 'examples' #950

merged 1 commit into from
Mar 18, 2025

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Mar 17, 2025

What changed / motivation ?

Renames the 'apps' dir to 'examples'. Going forward we can include more examples of app/bundler integrations, as well as non-app examples like a demo component library that can be imported into app examples.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2025
Copy link

github-actions bot commented Mar 17, 2025

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

[email protected] size:compare
node size/compare.js /tmp/tmp.LUvhSoE938 /tmp/tmp.CxZRjIXz7d

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 985 985 1.00
· minified 3,154 3,154 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
benchmarks/size/.build/bundle.js
· compressed 537,611 537,611 1.00
· minified 7,435,904 7,435,904 1.00
benchmarks/size/.build/stylex.css
· compressed 100,609 100,609 1.00
· minified 755,721 755,721 1.00

Copy link
Member

@mellyeliu mellyeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

component library + improved examples was an intern project idea I was thinking about for the upcoming summer internships, might share a project plan proposal

@necolas necolas force-pushed the rename-apps-to-examples branch from 21560dc to 24e5d3d Compare March 18, 2025 20:50
@necolas necolas merged commit ba07ebb into main Mar 18, 2025
8 checks passed
@necolas necolas deleted the rename-apps-to-examples branch March 19, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants