Reorganize monorepo scripts #953
Conversation
facebook-github-bot
added
the
CLA Signed
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
| @@ -11,7 +11,8 @@ | |||
| "prettier": "prettier --write \"**/*.js\" \"**/*.ts\"", | |||
| "prettier:report": "prettier --check \"**/*.js\"", | |||
| "lint": "npm run lint:report -- --fix", | |||
| "lint:report": "eslint", | |||
| "lint:report": "eslint packages tools", | |||
There was a problem hiding this comment.
eslint wasn't linting
| @@ -38,7 +39,7 @@ | |||
| "prettier": "^3.5.0", | |||
| "prettier-plugin-hermes-parser": "^0.26.0", | |||
| "rimraf": "^5.0.10", | |||
| "typescript": "^5.3.3" | |||
There was a problem hiding this comment.
typescript doesn't seem to be used by any monorepo tooling
|
ping @mellyeliu |
| @@ -1,37 +1,3 @@ | |||
| # @stylexjs/scripts | |||
| # scripts | |||
There was a problem hiding this comment.
what's the distinction we're making here between scripts and tools here? tools specifically as broader developer tooling unrelated to code logic?
There was a problem hiding this comment.
At the moment, everything left in scripts is installed as a bin in the dependent packages - so they're basically CLI tools used within some of the packages. The root tools are limited to managing monorepo-wide devx tasks like publishing to npm, precommit checks, etc. I'll add these notes to the READMEs
What changed / motivation ?
Minor reorganization of the repo's scripts and tools. Private package names aren't scoped to
@stylexjsand the release tooling is moved up to the root package.