Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete esbuild and webpack plugins #954

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Delete esbuild and webpack plugins #954

merged 1 commit into from
Mar 19, 2025

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Mar 19, 2025

What changed / motivation ?

Removes the remaining deprecated plugins - esbuild-plugin and webpack-plugin.

@necolas necolas requested review from nmn and mellyeliu March 19, 2025 19:15
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2025
Copy link

github-actions bot commented Mar 19, 2025

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

[email protected] size:compare
node size/compare.js /tmp/tmp.0ELHKt4xwp /tmp/tmp.ztjlFfCqmQ

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 985 985 1.00
· minified 3,154 3,154 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
benchmarks/size/.build/bundle.js
· compressed 537,611 537,611 1.00
· minified 7,435,904 7,435,904 1.00
benchmarks/size/.build/stylex.css
· compressed 100,609 100,609 1.00
· minified 755,721 755,721 1.00

@mellyeliu
Copy link
Member

mellyeliu commented Mar 19, 2025

looks like there's still some references to esbuild and webpack-plugin in packages/docs/docs/learn
/07-ecosystem.mdx
packages/docs/docs/learn/03-installation.mdx let's remove before landing

Copy link
Member

@mellyeliu mellyeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise!

@necolas
Copy link
Contributor Author

necolas commented Mar 19, 2025

Thanks, removed the content you pointed out.

@necolas necolas merged commit a72e7cb into main Mar 19, 2025
8 checks passed
@necolas necolas deleted the delete-some-plugins branch March 20, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants