Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve monorepo eslint config #957

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Improve monorepo eslint config #957

merged 1 commit into from
Mar 20, 2025

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Mar 20, 2025

  1. Fix the copyright header lint rule. Extra blank comment lines are now avoided. All pragmas are preserved.
  2. Get eslint to process *.mjs files.
  3. Update the React and Flow versions specified in the config.
  4. Lint the example directories.

@necolas necolas requested review from nmn and mellyeliu March 20, 2025 19:25
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2025 •
edited
Loading

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

[email protected] size:compare
node size/compare.js /tmp/tmp.qHG3bW3I5j /tmp/tmp.k1VYxmHrlT

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 985 985 1.00
· minified 3,154 3,154 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
benchmarks/size/.build/bundle.js
· compressed 537,611 537,611 1.00
· minified 7,435,904 7,435,904 1.00
benchmarks/size/.build/stylex.css
· compressed 100,609 100,609 1.00
· minified 755,721 755,721 1.00

@necolas
Improve monorepo eslint config
2d609ee 
1. Fix the copyright header lint rule. Extra blank comment lines are now
   avoided. All pragmas are preserved.
2. Get eslint to process `*.mjs` files.
3. Update the React and Flow versions specified in the config.
4. Lint the example directories.
@necolas necolas force-pushed the fix-eslint-config branch from 4a411b7 to 2d609ee Compare March 20, 2025 20:41
@nmn
Copy link
Contributor

nmn commented Mar 20, 2025

Fix the copyright header lint rule. Extra blank comment lines are now avoided. All pragmas are preserved.

Hallelujah! I struggled with this SO much! It's a trivial thing, but it has always bugged me!

@necolas necolas merged commit 91c518a into main Mar 20, 2025
8 checks passed
@nmn nmn deleted the fix-eslint-config branch March 20, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmn nmn nmn approved these changes

@mellyeliu mellyeliu Awaiting requested review from mellyeliu

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@necolas @nmn @facebook-github-bot