push misbehaving GMs to the back of the list #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53191500 |
Summary: Credit to yarikk for suggesting this idea. Because we trust local priority (when everything else is equal) we often end up jumping between time appliances. For instance when 1st in the list is unavailable we jump to a 2nd. However, once the 1st is available we switch back to it. This creates unnecessary noise and in some cases leads to offset oscillations. This diff will push 1st appliance to the end of the list and shift the rest of list up by 1. As a result we will keep running on 2nd appliance until and never fallback to 1st. Since we don't modify the config, restart will restore the order. Reviewed By: t3lurid3, vvfedorenko Differential Revision: D53191500
leoleovich
force-pushed
the
export-D53191500
branch
from
0577ea7 to
9e6a06f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53191500 |
|
This pull request has been merged in cb850c6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Credit to yarikk for suggesting this idea.
Because we trust local priority (when everything else is equal) we often end up jumping between time appliances.
For instance when 1st in the list is unavailable we jump to a 2nd. However, once the 1st is available we switch back to it. This creates unnecessary noise and in some cases leads to offset oscillations.
This diff will push 1st appliance to the end of the list and shift the rest of list up by 1.
As a result we will keep running on 2nd appliance until and never fallback to 1st.
Since we don't modify the config, restart will restore the order.
Reviewed By: t3lurid3
Differential Revision: D53191500