introduce ALTERNATE_RESPONSE_PORT TLV #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66656872 |
leoleovich
added a commit
to leoleovich/time
that referenced
this pull request
Dec 3, 2024
Summary: Introduce a new TLV as a POC to support switching port on the GM side. This is an important step torwards the asymmetry compensation. We use a count flag which is uint8 (256 combinations) which ensures consistency: ``` count 0 = noop count 1 = switch to the next available port count 2 = switch to the next next available port ... count 255 = you get the idea ``` As server doesn't keep the state, TLV with a desired offset count must be passed all the time Differential Revision: D66656872
leoleovich
force-pushed
the
export-D66656872
branch
from
e87cf1d to
e1745ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66656872 |
Summary: Introduce a new TLV as a POC to support switching port on the GM side. This is an important step torwards the asymmetry compensation. We use a count flag which is uint8 (256 combinations) which ensures consistency: ``` count 0 = noop count 1 = switch to the next available port count 2 = switch to the next next available port ... count 255 = you get the idea ``` As server doesn't keep the state, TLV with a desired offset count must be passed all the time Differential Revision: D66656872 [debug] fuzzing
leoleovich
force-pushed
the
export-D66656872
branch
from
e1745ab to
7c1850d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduce a new TLV as a POC to support switching port on the GM side.
This is an important step torwards the asymmetry compensation.
We use a count flag which is uint8 (256 combinations) which ensures consistency:
As server doesn't keep the state, TLV with a desired offset count must be passed all the time
Differential Revision: D66656872