Add decaf448 support #139
Draft
Add decaf448 support #139
+559
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
daxpedda
force-pushed
the
decaf448
branch
8 times, most recently
from
ec34342 to
1690d5e
Compare
|
Split MSRV bump off in #140. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for decaf448 based on RustCrypto/elliptic-curves#1121.
elliptic-curve& co. to v0.14.0-rc.1. It will still take a while for all these dependencies to release a stable version, see Tracking issue for next release series RustCrypto/traits#1571.Decaf448and implementCipherSuiteandGroup. This also adds thedecaf448anddecaf448-ciphersuitecrate feature.CipherSuitewithtype ExpandMsg, now that we aren't just usingexpand_message_xmd, but alsoexpand_message_xof. This also gets rid of a some constraints onCipherSuiteandGroupthat where only relevant forExpandMsgXmd.u16::MAX, the only real constraint set upon the hash size by the protocol: https://www.rfc-editor.org/rfc/rfc9497#section-2.2.1-5.I2OSP(len(seed), 2), theseedis a hash output, which would fail if its length doesn't fit into au16here.Group::ElemLenwithIsLess<U65536>, which gets rid of a potential runtime error, that is now moved to compile time.Based on #140.