Skip to content

Upgrade GitHub Actions for Node 24 compatibility #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salmanmkc wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −21
Open

Upgrade GitHub Actions for Node 24 compatibility #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/getdeps_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
build:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Show disk space at start
run: df -h
- name: Free up disk space
Expand Down Expand Up @@ -702,7 +702,7 @@ jobs:
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. watchman --project-install-prefix watchman:/usr/local
- name: Copy artifacts
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --strip --src-dir=. watchman _artifacts/linux --project-install-prefix watchman:/usr/local --final-install-prefix /usr/local
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v6
with:
name: watchman
path: _artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/getdeps_mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
build:
runs-on: macOS-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Show disk space at start
run: df -h
- name: Free up disk space
Expand Down Expand Up @@ -662,7 +662,7 @@ jobs:
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. watchman --project-install-prefix watchman:/usr/local
- name: Copy artifacts
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --src-dir=. watchman _artifacts/mac --project-install-prefix watchman:/usr/local --final-install-prefix /usr/local
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v6
with:
name: watchman
path: _artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/getdeps_windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
git config --system core.autocrlf false &&
git config --system core.symlinks true
shell: cmd
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- id: paths
name: Query paths
run: python build/fbcode_builder/getdeps.py query-paths --recursive --src-dir=. watchman >> $env:GITHUB_OUTPUT
Expand Down Expand Up @@ -626,7 +626,7 @@ jobs:
run: python build/fbcode_builder/getdeps.py build --src-dir=. watchman
- name: Copy artifacts
run: python build/fbcode_builder/getdeps.py fixup-dyn-deps --src-dir=. watchman _artifacts/windows --final-install-prefix /usr/local
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v6
with:
name: watchman
path: _artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
Expand Down Expand Up @@ -35,7 +35,7 @@ jobs:
image: ${{ format('ghcr.io/{0}/watchman-build-env:latest', github.repository) }}
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: rustup default stable
run: rustup default stable
Expand Down
26 changes: 13 additions & 13 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Login to GitHub Container Registry
Expand All @@ -53,7 +53,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Login to GitHub Container Registry
Expand All @@ -74,7 +74,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Login to GitHub Container Registry
Expand All @@ -95,7 +95,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Login to GitHub Container Registry
Expand All @@ -116,7 +116,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Login to GitHub Container Registry
Expand Down Expand Up @@ -144,7 +144,7 @@ jobs:
- name: Fix HOME
run: echo HOME=/root >> $GITHUB_ENV
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Install system dependencies
run: "./install-system-packages.sh"
- name: Fix dubious ownership
Expand Down Expand Up @@ -175,7 +175,7 @@ jobs:
- name: Fix HOME
run: echo HOME=/root >> $GITHUB_ENV
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Install system dependencies
run: "./install-system-packages.sh"
- name: Fix dubious ownership
Expand Down Expand Up @@ -206,7 +206,7 @@ jobs:
- name: Fix HOME
run: echo HOME=/root >> $GITHUB_ENV
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Install system dependencies
run: "./install-system-packages.sh"
- name: Fix dubious ownership
Expand Down Expand Up @@ -238,7 +238,7 @@ jobs:
- name: Fix HOME
run: echo HOME=/root >> $GITHUB_ENV
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Install system dependencies
run: "./install-system-packages.sh"
- name: Fix dubious ownership
Expand Down Expand Up @@ -270,7 +270,7 @@ jobs:
- name: Fix HOME
run: echo HOME=/root >> $GITHUB_ENV
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Install system dependencies
run: "./install-system-packages.sh"
- name: Fix dubious ownership
Expand All @@ -296,7 +296,7 @@ jobs:
needs: prepare
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Build watchman
run: "python3 build/fbcode_builder/getdeps.py build --src-dir=. watchman --project-install-prefix watchman:/usr/local"
- name: Copy artifacts
Expand All @@ -319,7 +319,7 @@ jobs:
needs: prepare
runs-on: macOS-10.15
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Build watchman
run: "SDKROOT=$(xcrun --show-sdk-path --sdk macosx11.1) python3 build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. watchman --project-install-prefix watchman:/usr/local"
- name: Copy artifacts
Expand All @@ -342,7 +342,7 @@ jobs:
needs: prepare
runs-on: windows-2019
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Export boost environment
run: echo BOOST_ROOT=%BOOST_ROOT_1_69_0% >> %GITHUB_ENV%
shell: cmd
Expand Down