Use system liblzma but bundled libunwind on Ubuntu#1338
Open
mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
Open
Use system liblzma but bundled libunwind on Ubuntu#1338mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
Conversation
D66446570 disabled using the system liblzma, libunwind and glog packages on Ubuntu due to them causing watchman's tests to hang when run in GitHub Actions, and D86604386 confirmed this still happens with Ubuntu Noble. The original investigation noted that Fedora 40 didn't exhibit this behavior. The main difference I see is that Fedora 40 packages libunwind 1.8.0 while Ubuntu Jammy packages 1.3.2 and Noble 1.6.2. Fedora also doesn't build its libunwind with liblzma support. However, the autotools build system in libunwind tries to enable minidebuginfo support by default, which is what looks for liblzma, so the CI has been using libunwind built with liblzma support anyways. Thus I think the cause is not the liblzma package in Ubuntu but rather the old libunwind version. Building these deps from source via getdeps has been rather painful for OSS consumers since it produces shared object libraries that needs to be shipped alongside watchman. See facebook#1276, facebook#1273 for resulting complaints. Conveniently, as of last week we should automatically build and consume a static libunwind thanks to D93644457, so that issue should solve itself once GitHub Actions caches expire. So, let's allow using system liblzma on Ubuntu and update the other comments to incriminate libunwind instead of liblzma. Tested at https://github.com/mszabo-wikia/watchman/actions/runs/22643456785/job/65625279878?pr=1 Fixes facebook#1276, fixes facebook#1273.
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D95118676. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D66446570 disabled using the system liblzma, libunwind and glog packages on Ubuntu due to them causing watchman's tests to hang when run in GitHub Actions, and D86604386 confirmed this still happens with Ubuntu Noble.
The original investigation noted that Fedora 40 didn't exhibit this behavior. The main difference I see is that Fedora 40 packages libunwind 1.8.0 while Ubuntu Jammy packages 1.3.2 and Noble 1.6.2. Fedora also doesn't build its libunwind with liblzma support. However, the autotools build system in libunwind tries to enable minidebuginfo support by default, which is what looks for liblzma, so the CI has been using libunwind built with liblzma support anyways. Thus I think the cause is not the liblzma package in Ubuntu but rather the old libunwind version.
Building these deps from source via getdeps has been rather painful for OSS consumers since it produces shared object libraries that needs to be shipped alongside watchman. See #1276, #1273 for resulting complaints. Conveniently, as of last week we should automatically build and consume a static libunwind thanks to D93644457, so that issue should solve itself once GitHub Actions caches expire. So, let's allow using system liblzma on Ubuntu and update the other comments to incriminate libunwind instead of liblzma.
Tested at https://github.com/mszabo-wikia/watchman/actions/runs/22643456785/job/65625279878?pr=1
Fixes #1276, fixes #1273.