Skip to content

Commit cd0c6fd

Browse files
J8118meta-codesync[bot]
authored andcommitted
Remove commented-out duplicate code in YGMeasureTest (#1927)
Summary: Remove three commented-out `YGNodeSetMeasureFunc` calls in `tests/YGMeasureTest.cpp` that are exact duplicates of the active calls on adjacent lines. All three were introduced in commit `fbd332d` (2017-12-19) and left behind when the active lines were later updated by other authors. Each commented-out line sits directly next to its active duplicate: - Line 248 (commented) / line 249 (active) - Line 337 (commented) / line 336 (active) - Line 376 (commented) / line 377 (active) Pull Request resolved: #1927 Test Plan: - No behavioral changes — only removes dead commented-out code - The active `YGNodeSetMeasureFunc` calls remain unchanged Reviewed By: NickGerleman Differential Revision: D100144096 Pulled By: fabriziocucci fbshipit-source-id: 3fed15a5dc9fde0fa653e559fc0a2de2f1ce315b
1 parent 0ea34b7 commit cd0c6fd

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

tests/YGMeasureTest.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,6 @@ TEST(YogaTest, measure_not_enough_size_should_wrap) {
245245

246246
YGNodeRef root_child0 = YGNodeNew();
247247
YGNodeStyleSetAlignSelf(root_child0, YGAlignFlexStart);
248-
// YGNodeSetMeasureFunc(root_child0, _simulate_wrapping_text);
249248
YGNodeSetMeasureFunc(root_child0, _simulate_wrapping_text);
250249
YGNodeInsertChild(root, root_child0, 0);
251250

@@ -334,7 +333,6 @@ TEST(YogaTest, measure_flex_direction_column_and_padding) {
334333

335334
YGNodeRef root_child0 = YGNodeNewWithConfig(config);
336335
YGNodeSetMeasureFunc(root_child0, _simulate_wrapping_text);
337-
// YGNodeSetMeasureFunc(root_child0, _simulate_wrapping_text);
338336
YGNodeInsertChild(root, root_child0, 0);
339337

340338
YGNodeRef root_child1 = YGNodeNewWithConfig(config);
@@ -373,7 +371,6 @@ TEST(YogaTest, measure_flex_direction_row_no_padding) {
373371
YGNodeStyleSetHeight(root, 50);
374372

375373
YGNodeRef root_child0 = YGNodeNewWithConfig(config);
376-
// YGNodeSetMeasureFunc(root_child0, _simulate_wrapping_text);
377374
YGNodeSetMeasureFunc(root_child0, _simulate_wrapping_text);
378375
YGNodeInsertChild(root, root_child0, 0);
379376

0 commit comments

Comments
 (0)