Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where we were not applying flex end correctly when justifying #1487

Closed
wants to merge 8 commits into from
+7,046 −202
Closed

Fix issue where we were not applying flex end correctly when justifying #1487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
01f7f44
Make positionAbsoluteChild the sole place that matters when determini…
Dec 7, 2023
2349a2a
Make position static behave like position static (#1482)
joevilches Dec 7, 2023
8a0d5a6
Fix issue where percentages were off of the border box, not padding b…
Dec 7, 2023
c40e044
Relayout test for containing block changing size
Dec 7, 2023
5c6d764
Fix bug with align start not taking into account parent padding
Dec 7, 2023
35cc833
Fix bug where we used border box for size of containing block in a ce…
Dec 7, 2023
83b3ead
Fix issue where we were not centering absolute nodes correctly when j…
Dec 7, 2023
e69cd7a
Fix issue where we were not applying flex end correctly when justifyi…
joevilches Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@
("StartingEndingEdgeFromFlexDirection", 1 << 1),
# Position: static behaves like position: relative within Yoga
("PositionStaticBehavesLikeRelative", 1 << 2),
# Positioning of absolute nodes will have various bugs related to
# justification, alignment, and insets
("AbsolutePositioning", 1 << 3),
# Enable all incorrect behavior (preserve compatibility)
("All", 0x7FFFFFFF),
# Enable all errata except for "StretchFlexBasis" (Defaults behavior
Expand Down
2 changes: 1 addition & 1 deletion gentest/fixtures/YGAbsolutePositionTest.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
<div style="width:20%; height:20%; left:20%; top:20%; position: absolute;"></div>
</div>

<div id="absolute_layout_percentage_height_based_on_padded_parent" data-disabled="true" style="flex-direction:column; width:100px; height:100px; padding-top: 10px; border-top: 10px solid black;">
<div id="absolute_layout_percentage_height_based_on_padded_parent" style="flex-direction:column; width:100px; height:100px; padding-top: 10px; border-top: 10px solid black;">
<div style="width:100px; height:50%; position: absolute;"></div>
</div>

Expand Down
299 changes: 265 additions & 34 deletions gentest/fixtures/YGStaticPositionTest.html
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions java/com/facebook/yoga/YogaErrata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ public enum YogaErrata {
STRETCH_FLEX_BASIS(1),
STARTING_ENDING_EDGE_FROM_FLEX_DIRECTION(2),
POSITION_STATIC_BEHAVES_LIKE_RELATIVE(4),
ABSOLUTE_POSITIONING(8),
ALL(2147483647),
CLASSIC(2147483646);

Expand All @@ -33,6 +34,7 @@ public static YogaErrata fromInt(int value) {
case 1: return STRETCH_FLEX_BASIS;
case 2: return STARTING_ENDING_EDGE_FROM_FLEX_DIRECTION;
case 4: return POSITION_STATIC_BEHAVES_LIKE_RELATIVE;
case 8: return ABSOLUTE_POSITIONING;
case 2147483647: return ALL;
case 2147483646: return CLASSIC;
default: throw new IllegalArgumentException("Unknown enum value: " + value);
Expand Down
2,115 changes: 2,081 additions & 34 deletions java/tests/com/facebook/yoga/YGStaticPositionTest.java
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions javascript/src/generated/YGEnums.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export enum Errata {
StretchFlexBasis = 1,
StartingEndingEdgeFromFlexDirection = 2,
PositionStaticBehavesLikeRelative = 4,
AbsolutePositioning = 8,
All = 2147483647,
Classic = 2147483646,
}
Expand Down Expand Up @@ -164,6 +165,7 @@ const constants = {
ERRATA_STRETCH_FLEX_BASIS: Errata.StretchFlexBasis,
ERRATA_STARTING_ENDING_EDGE_FROM_FLEX_DIRECTION: Errata.StartingEndingEdgeFromFlexDirection,
ERRATA_POSITION_STATIC_BEHAVES_LIKE_RELATIVE: Errata.PositionStaticBehavesLikeRelative,
ERRATA_ABSOLUTE_POSITIONING: Errata.AbsolutePositioning,
ERRATA_ALL: Errata.All,
ERRATA_CLASSIC: Errata.Classic,
EXPERIMENTAL_FEATURE_WEB_FLEX_BASIS: ExperimentalFeature.WebFlexBasis,
Expand Down
Loading
Loading