Remove ruby files and regen tests #1501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51956567 |
|
This pull request was exported from Phabricator. Differential Revision: D51956567 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 11, 2023
Summary: Pull Request resolved: facebook#1501 Now that we have `gentest-driver.ts` we can delete the ruby gentest. I also regened all of the tests that have a comment with the wrong file name for where it was generated. Differential Revision: D51956567 fbshipit-source-id: 05c64ecb64c35dd9edf1e618bc664fe36e874166
joevilches
force-pushed
the
export-D51956567
branch
from
afe580a to
e7633e7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51956567 |
joevilches
force-pushed
the
export-D51956567
branch
from
e7633e7 to
9fc5b35
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 12, 2023
Summary: Pull Request resolved: facebook#1501 Now that we have `gentest-driver.ts` we can delete the ruby gentest. I also regened all of the tests that have a comment with the wrong file name for where it was generated. Reviewed By: yungsters, NickGerleman Differential Revision: D51956567 fbshipit-source-id: 875afd501de0b0cd7efcd1ed48001d0e58b24e74
|
This pull request was exported from Phabricator. Differential Revision: D51956567 |
joevilches
force-pushed
the
export-D51956567
branch
from
9fc5b35 to
1847442
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 13, 2023
Summary: Pull Request resolved: facebook#1501 Now that we have `gentest-driver.ts` we can delete the ruby gentest. I also regened all of the tests that have a comment with the wrong file name for where it was generated. Reviewed By: yungsters, NickGerleman Differential Revision: D51956567 fbshipit-source-id: 01a65ce2f9a0f57d292d2262e27ca203ae2ecbe7
Summary: The only instance of ruby in this repository is `gentest.rb` used to generate test cases from html fixtures. This is quite annoying as ruby is not the most popular compared to something like Node and it does not integrate into the rest of our stack. I changed this to use Node.js instead. Instead of `watir` we now use `selenium-webdriver`. `watir` is backed by Selenium so I do not expect anything to change. Next commits will add command line options, clean up gentest.rb and its references, and change the README Differential Revision: https://www.internalfb.com/diff/D51874433?entry_point=27 fbshipit-source-id: 586a201cb5741241d2402f9dfd5bc382863e8d89
Summary: This uses the minimist library to parse the command line easily for flags and options. I added over the same ones in the ruby script (-f and -s). Unfortunately, there seems to be no way to fully suspend the script on command while waiting for user input like how you can in ruby. So, I am only able to suspend at the very end by not closing the browser immediately. Therefore, I only let this happen if -f is specified. Differential Revision: https://www.internalfb.com/diff/D51877810?entry_point=27 fbshipit-source-id: a681c647f2cfcf39dd724cea7d2505f61d125318
Summary: Pull Request resolved: facebook#1501 Now that we have `gentest-driver.ts` we can delete the ruby gentest. I also regened all of the tests that have a comment with the wrong file name for where it was generated. Reviewed By: yungsters, NickGerleman Differential Revision: D51956567 fbshipit-source-id: 1e09f5fdee762e2de37e3e54bc713486bbcb7158
|
This pull request was exported from Phabricator. Differential Revision: D51956567 |
joevilches
force-pushed
the
export-D51956567
branch
from
1847442 to
2ad3e9d
Compare
|
This pull request has been merged in e61eb01. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Now that we have
gentest-driver.tswe can delete the ruby gentest. I also regened all of the tests that have a comment with the wrong file name for where it was generated.Differential Revision: D51956567