Change Style::resolveColumnGap() return from Length to Style::Length #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D52096820 |
NickGerleman
force-pushed
the
export-D52096820
branch
from
d54dae8 to
5f79161
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 17, 2023
…acebook#1525) Summary: Accidentally left this inconsistent with some of the refactoring. Rename the lone usage of `Length` within Style class to `Style::Length` to match the rest of the code. This is functionally identical as before. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D52096820
|
This pull request was exported from Phabricator. Differential Revision: D52096820 |
…acebook#1525) Summary: Accidentally left this inconsistent with some of the refactoring. Rename the lone usage of `Length` within Style class to `Style::Length` to match the rest of the code. This is functionally identical as before. Changelog: [Internal] bypass-github-export-checks Reviewed By: yungsters Differential Revision: D52096820
NickGerleman
force-pushed
the
export-D52096820
branch
from
5f79161 to
63257ee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52096820 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Dec 17, 2023
Summary: X-link: facebook/yoga#1525 Accidentally left this inconsistent with some of the refactoring. Rename the lone usage of `Length` within Style class to `Style::Length` to match the rest of the code. This is functionally identical as before. Changelog: [Internal] bypass-github-export-checks Reviewed By: yungsters Differential Revision: D52096820 fbshipit-source-id: d6c569a02fb27a6e7548a9c12ff764afb823a282
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 17, 2023
Summary: X-link: facebook/yoga#1525 Accidentally left this inconsistent with some of the refactoring. Rename the lone usage of `Length` within Style class to `Style::Length` to match the rest of the code. This is functionally identical as before. Changelog: [Internal] bypass-github-export-checks Reviewed By: yungsters Differential Revision: D52096820 fbshipit-source-id: d6c569a02fb27a6e7548a9c12ff764afb823a282
|
This pull request has been merged in 3f3b909. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebook/yoga#1525 Accidentally left this inconsistent with some of the refactoring. Rename the lone usage of `Length` within Style class to `Style::Length` to match the rest of the code. This is functionally identical as before. Changelog: [Internal] bypass-github-export-checks Reviewed By: yungsters Differential Revision: D52096820 fbshipit-source-id: d6c569a02fb27a6e7548a9c12ff764afb823a282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Accidentally left this inconsistent with some of the refactoring. Rename the lone usage of
Lengthwithin Style class toStyle::Lengthto match the rest of the code.This is functionally identical as before.
Changelog: [Internal]
Reviewed By: yungsters
Differential Revision: D52096820