Fix misc-misplaced-const warnings in Yoga tests
#1677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1674) Summary: This is a continuation of the previous PR: facebook/react-native#45047 I made the change more generic for allowing any kind of config change to invalidate layout. Pull Request resolved: facebook#1674 Differential Revision: D59286992 Pulled By: NickGerleman
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D59335968 |
Summary: Pull Request resolved: facebook#1677 We have Clang Tidy warnings enabled internally, that will flag `const YG*Ref` as misleading, as a const pointer to non-const, instead of non-const pointer to const. Let's remove all the misleading const in existing tests, and generatedr tests. Reviewed By: joevilches Differential Revision: D59335968
NickGerleman
force-pushed
the
export-D59335968
branch
from
ec1822b to
e03a81a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59335968 |
|
This pull request has been merged in 5009f5c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have Clang Tidy warnings enabled internally, that will flag
const YG*Refas misleading, as a const pointer to non-const, instead of non-const pointer to const.Let's remove all the misleading const in existing tests, and generatedr tests.
Differential Revision: D59335968