Let gentest properly create *Auto methods for sizes #1719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ook#1718) Summary: Our gentest works by console.logging the contents of the test it is generating to the browser powered by the driver. The driver then reads the logs and writes it to a file. An unfortunate side effect here is that we cannot console.log to debug how the gentest logic actually works since the driver is expecting formatted code. To get around this I had the driver filter out logs with a certain prefix and add that a helper that logs a message with this prefix to the scripts. Differential Revision: D64011035
Summary: Right now there is no way to test fixtures with `auto` widths, heights, or flex basis - even though we expose those functions. I updated gentest to generate those functions. Notably, position and margin (the other auto-able props) already account for this. I also created `YGAutoTest.html` to test this. Not really testing the capabilities of `auto` here, just if we can create a test about it. Differential Revision: D64125522
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D64125522 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 9, 2024
Summary: Right now there is no way to test fixtures with `auto` widths, heights, or flex basis - even though we expose those functions. I updated gentest to generate those functions. Notably, position and margin (the other auto-able props) already account for this. I also created `YGAutoTest.html` to test this. Not really testing the capabilities of `auto` here, just if we can create a test about it. Differential Revision: D64125522
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 9, 2024
Summary: Right now there is no way to test fixtures with `auto` widths, heights, or flex basis - even though we expose those functions. I updated gentest to generate those functions. Notably, position and margin (the other auto-able props) already account for this. I also created `YGAutoTest.html` to test this. Not really testing the capabilities of `auto` here, just if we can create a test about it. Reviewed By: NickGerleman Differential Revision: D64125522
|
This pull request has been merged in 820a4d5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Right now there is no way to test fixtures with
autowidths, heights, or flex basis - even though we expose those functions. I updated gentest to generate those functions. Notably, position and margin (the other auto-able props) already account for this.I also created
YGAutoTest.htmlto test this. Not really testing the capabilities ofautohere, just if we can create a test about it.Differential Revision: D64125522