Migrate YogaProps to Kotlin#1844
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D79897771. |
1 similar comment
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D79897771. |
|
This is breaking a bunch of stuff internally because is made in a breaking manner. Here an example of what breaks. Can you update this to use val so that it doesn't break with Litho? |
|
Thanks! Could you please take a second pass? I updated the possible getters to vals in 19b96f5. |
|
Landing this will be a bit more complicated that I thought. Leave it to me, I'll take care of it (we might have to resort to land the original version) |
Summary: Pull Request resolved: facebook#55349 Migrate com.facebook.yoga.YogaProps to Kotlin. X-link: facebook/yoga#1844 Test Plan: RN ```sh yarn android yarn test-android ``` Yoga ```sh ./gradlew :yoga:assembleDebug ``` Reviewed By: rshest Differential Revision: D79897771 Pulled By: cortinico
|
@cortinico merged this pull request in 32ec5d5. |
Summary: Pull Request resolved: #55349 Migrate com.facebook.yoga.YogaProps to Kotlin. X-link: facebook/yoga#1844 Test Plan: RN ```sh yarn android yarn test-android ``` Yoga ```sh ./gradlew :yoga:assembleDebug ``` Reviewed By: rshest Differential Revision: D79897771 Pulled By: cortinico fbshipit-source-id: 65052bca9a26bbb1f0a56bcbcc75403fa2fdcd71
Migrate com.facebook.yoga.YogaProps to Kotlin.
Test plan:
RN
Yoga