Skip to content

Make gentest headless by default #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NickGerleman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make gentest headless by default #1878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/validate-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
run: yarn gentest-validate

- name: yarn gentest
run: yarn gentest -h
run: yarn gentest

- name: Check for modified tests
run: |
Expand Down
6 changes: 4 additions & 2 deletions gentest/gentest-driver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function addSignatureToSourceCode(sourceCode: string): string {
const argv = minimist(process.argv.slice(2));
const specificFixture = argv.f || argv.fixture;
const suspend = argv.s || argv.suspend;
const headless = argv.h || argv.headless;
const createWindow = argv.w || argv['create-window'];

const gentestDir = dirname(fileURLToPath(import.meta.url));
const yogaDir = dirname(gentestDir);
Expand All @@ -55,7 +55,9 @@ options.addArguments(
'--window-position=0,0',
'--hide-scrollbars',
);
headless && options.addArguments('--headless');
if (!createWindow) {
options.addArguments('--headless');
}
options.setLoggingPrefs({
browser: 'ALL',
performance: 'ALL',
Expand Down
Loading