Skip to content

Back out "Add fixYogaFlexBasisFitContentInMainAxis flag to avoid unnecessary re-measurement" #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixelfreak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Back out "Add fixYogaFlexBasisFitContentInMainAxis flag to avoid unnecessary re-measurement" #1911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,6 @@
# Absolute nodes will resolve percentages against the inner size of
# their containing node, not the padding box
("AbsolutePercentAgainstInnerSize", 1 << 2),
# Applies a FitContent constraint in the main axis during flex basis
# computation for non-measure container nodes
("FlexBasisFitContentInMainAxis", 1 << 3),
# Enable all incorrect behavior (preserve compatibility)
("All", 0x7FFFFFFF),
# Enable all errata except for "StretchFlexBasis" (Defaults behavior
Expand Down
68 changes: 0 additions & 68 deletions gentest/fixtures/YGFlexBasisFitContentInMainAxisTest.html
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions java/com/facebook/yoga/YogaErrata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ public enum YogaErrata {
STRETCH_FLEX_BASIS(1),
ABSOLUTE_POSITION_WITHOUT_INSETS_EXCLUDES_PADDING(2),
ABSOLUTE_PERCENT_AGAINST_INNER_SIZE(4),
FLEX_BASIS_FIT_CONTENT_IN_MAIN_AXIS(8),
ALL(2147483647),
CLASSIC(2147483646);

Expand All @@ -34,7 +33,6 @@ public static YogaErrata fromInt(int value) {
case 1: return STRETCH_FLEX_BASIS;
case 2: return ABSOLUTE_POSITION_WITHOUT_INSETS_EXCLUDES_PADDING;
case 4: return ABSOLUTE_PERCENT_AGAINST_INNER_SIZE;
case 8: return FLEX_BASIS_FIT_CONTENT_IN_MAIN_AXIS;
case 2147483647: return ALL;
case 2147483646: return CLASSIC;
default: throw new IllegalArgumentException("Unknown enum value: " + value);
Expand Down
Loading
Loading