Fix baseline layout NaN asent value returned by calculateBaseline#1933
Open
hzxiaosheng wants to merge 2 commits into
Open
Fix baseline layout NaN asent value returned by calculateBaseline#1933hzxiaosheng wants to merge 2 commits into
hzxiaosheng wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hzxiaosheng
changed the title
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this MR fix #1932 calculateBaseline(node) may return NaN if the baselineChild has not been measured.
A NaN value returned from calculateBaseline(node) disrupts Yoga's layout engine, leading to incorrect ascent, descent, and line height calculations. This issue is critical when a parent node uses alignItems: 'baseline', causing improper vertical alignment and height calculation.