Migrate YogaNodeJNIBase.java to Kotlin (#1939)#1939
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104666335. |
cortinico
force-pushed
the
export-D104666335
branch
from
9b61740 to
91e3b84
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 12, 2026
Summary: X-link: facebook/yoga#1939 Pull Request resolved: facebook#56780 Migrate YogaNodeJNIBase.java to YogaNodeJNIBase.kt, the last hand-written Java source file in the Yoga core library. This required converting all function overrides to Kotlin property overrides where the abstract YogaNode class declares them as val/var properties. Also changed nativePointer visibility in YogaConfigJNIBase from protected to internal to maintain same-module access that Java protected provided via package access. Changelog: [Internal] - Differential Revision: D104666335
meta-codesync
Bot
changed the title
cortinico
force-pushed
the
export-D104666335
branch
from
91e3b84 to
4342881
Compare
cortinico
added a commit
to cortinico/yoga
that referenced
this pull request
May 13, 2026
Summary: Pull Request resolved: facebook#1939 X-link: facebook/react-native#56780 Migrate YogaNodeJNIBase.java to YogaNodeJNIBase.kt, the last hand-written Java source file in the Yoga core library. This required converting all function overrides to Kotlin property overrides where the abstract YogaNode class declares them as val/var properties. Also changed nativePointer visibility in YogaConfigJNIBase from protected to internal to maintain same-module access that Java protected provided via package access. Changelog: [Internal] - Differential Revision: D104666335
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 13, 2026
Summary: X-link: facebook/yoga#1939 Pull Request resolved: facebook#56780 Migrate YogaNodeJNIBase.java to YogaNodeJNIBase.kt, the last hand-written Java source file in the Yoga core library. This required converting all function overrides to Kotlin property overrides where the abstract YogaNode class declares them as val/var properties. Also changed nativePointer visibility in YogaConfigJNIBase from protected to internal to maintain same-module access that Java protected provided via package access. Changelog: [Internal] - Differential Revision: D104666335
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 13, 2026
Summary: X-link: facebook/yoga#1939 Pull Request resolved: facebook#56780 Migrate YogaNodeJNIBase.java to YogaNodeJNIBase.kt, the last hand-written Java source file in the Yoga core library. This required converting all function overrides to Kotlin property overrides where the abstract YogaNode class declares them as val/var properties. Also changed nativePointer visibility in YogaConfigJNIBase from protected to internal to maintain same-module access that Java protected provided via package access. Changelog: [Internal] - Differential Revision: D104666335
cortinico
added a commit
to cortinico/yoga
that referenced
this pull request
May 13, 2026
Summary: Pull Request resolved: facebook#1939 X-link: facebook/react-native#56780 Migrate YogaNodeJNIBase.java to YogaNodeJNIBase.kt, the last hand-written Java source file in the Yoga core library. This required converting all function overrides to Kotlin property overrides where the abstract YogaNode class declares them as val/var properties. Also changed nativePointer visibility in YogaConfigJNIBase from protected to internal to maintain same-module access that Java protected provided via package access. Changelog: [Internal] - Differential Revision: D104666335
cortinico
force-pushed
the
export-D104666335
branch
from
4342881 to
3907ff5
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 13, 2026
Summary: X-link: facebook/yoga#1939 Pull Request resolved: facebook#56780 Migrate YogaNodeJNIBase.java to YogaNodeJNIBase.kt, the last hand-written Java source file in the Yoga core library. This required converting all function overrides to Kotlin property overrides where the abstract YogaNode class declares them as val/var properties. Also changed nativePointer visibility in YogaConfigJNIBase from protected to internal to maintain same-module access that Java protected provided via package access. Changelog: [Internal] - Differential Revision: D104666335
cortinico
added a commit
to cortinico/yoga
that referenced
this pull request
May 13, 2026
Summary: Pull Request resolved: facebook#1939 X-link: facebook/react-native#56780 Migrate YogaNodeJNIBase.java to YogaNodeJNIBase.kt, the last hand-written Java source file in the Yoga core library. This required converting all function overrides to Kotlin property overrides where the abstract YogaNode class declares them as val/var properties. Also changed nativePointer visibility in YogaConfigJNIBase from protected to internal to maintain same-module access that Java protected provided via package access. Changelog: [Internal] - Differential Revision: D104666335
cortinico
force-pushed
the
export-D104666335
branch
from
3907ff5 to
559dab5
Compare
Summary: Pull Request resolved: facebook#1939 X-link: facebook/react-native#56780 Migrate YogaNodeJNIBase.java to YogaNodeJNIBase.kt, the last hand-written Java source file in the Yoga core library. This required converting all function overrides to Kotlin property overrides where the abstract YogaNode class declares them as val/var properties. Also changed nativePointer visibility in YogaConfigJNIBase from protected to internal to maintain same-module access that Java protected provided via package access. Changelog: [Internal] - Differential Revision: D104666335
cortinico
force-pushed
the
export-D104666335
branch
from
559dab5 to
bac628f
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 13, 2026
Summary: X-link: facebook/yoga#1939 Pull Request resolved: facebook#56780 Migrate YogaNodeJNIBase.java to YogaNodeJNIBase.kt, the last hand-written Java source file in the Yoga core library. This required converting all function overrides to Kotlin property overrides where the abstract YogaNode class declares them as val/var properties. Also changed nativePointer visibility in YogaConfigJNIBase from protected to internal to maintain same-module access that Java protected provided via package access. Changelog: [Internal] - Differential Revision: D104666335
|
This pull request has been merged in e114242. |
meta-codesync Bot
pushed a commit
to facebook/react-native
that referenced
this pull request
May 15, 2026
Summary: X-link: facebook/yoga#1939 Pull Request resolved: #56780 Migrate YogaNodeJNIBase.java to YogaNodeJNIBase.kt, the last hand-written Java source file in the Yoga core library. This required converting all function overrides to Kotlin property overrides where the abstract YogaNode class declares them as val/var properties. Also changed nativePointer visibility in YogaConfigJNIBase from protected to internal to maintain same-module access that Java protected provided via package access. Changelog: [Internal] - Reviewed By: alanleedev Differential Revision: D104666335 fbshipit-source-id: c60285453e8a6ec834924be461da3c669d9a7be4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#56780
Migrate YogaNodeJNIBase.java to YogaNodeJNIBase.kt, the last hand-written Java source file in the Yoga core library. This required converting all function overrides to Kotlin property overrides where the abstract YogaNode class declares them as val/var properties. Also changed nativePointer visibility in YogaConfigJNIBase from protected to internal to maintain same-module access that Java protected provided via package access.
Changelog:
[Internal] -
Differential Revision: D104666335