Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM's assembly code for huffman decoding #4204

Closed
wants to merge 11 commits into from
Closed

Conversation

Nicoshev
Copy link

We would like to have a dedicated ARM's asm function for decoding huffman

@JunHe77
Copy link
Contributor

JunHe77 commented Dec 2, 2024

Would be good to add PAC and BTI support, #3961 could be referred for adding BTI description in section

@terrelln
Copy link
Contributor

terrelln commented Feb 7, 2025

The latest clang-trunk and gcc-14 both match or beat the assembly performance for both 4x1 and 4x2 using the "fast C" decoding loops.

Given that newer compilers perform just as well or better, and the maintenance burden of adding more assembly, we will not be merging this upstream. Adding non-x86-64 assembly makes it very hard to fuzz test the code. And down the line I would love to also delete the x86-64 assembly. Maintaining assembly in Zstd has ended up being a huge PITA, due to the huge number of platforms & compilers we support.

Thanks for the PR @Nicoshev!

@terrelln terrelln closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants