Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check API manual and man pages before release #4309

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

Cyan4973
Copy link
Contributor

@Cyan4973 Cyan4973 commented Feb 20, 2025

This PR adds 2 checks in CI
to ensure that the man pages and the API manual are correctly updated before reaching the release branch.

This will avoid issues like #4301 in the future.

These new tests are triggered when merging or presenting a PR onto the release branch (only).
They were tested in my local fork.
For instance, after making an intentional modification to zstd.1.md, it triggered the following error signal: https://github.com/Cyan4973/zstd/actions/runs/13444836104/job/37567684872?pr=4

@Cyan4973 Cyan4973 self-assigned this Feb 20, 2025
@Cyan4973 Cyan4973 merged commit 3ff0d79 into facebook:dev Feb 24, 2025
100 checks passed
@Cyan4973 Cyan4973 deleted the check_manual branch February 27, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants