Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add library.json file to support esp32 target via Platformio #4343

Closed
wants to merge 1 commit into from

Conversation

mhaberler
Copy link

@facebook-github-bot
Copy link

Hi @mhaberler!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Cyan4973
Copy link
Contributor

Thank you for contributing, @mhaberler. Your solution likely works as intended. However, the upstream repository isn’t the place to support every package manager. We aim to keep the repository’s root directory free of special-case files and only add features we can reliably maintain over time.

In this case, a dedicated fork for PlatformIO would be ideal. That fork would include and maintain the additional file, updating it whenever a new release occurs. (For instance, the “version” field is still set to v1.5.5.)

@Cyan4973 Cyan4973 self-assigned this Mar 22, 2025
@Cyan4973 Cyan4973 closed this Mar 22, 2025
@mhaberler
Copy link
Author

fair enough.

I will keep it in my fork in the platformio branch and rebase as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants