Skip to content

Conversation

@rzikm
Copy link
Contributor

@rzikm rzikm commented Oct 2, 2025

Having ASM enabled unconditionally by zstd on MSVC causes weird configure-time issues in larger projects where other parts use some kind of assembly langugage.

This PR removes the ASM language from the project() macro and conditionally enables via enable_language(ASM) when needed.

@meta-cla
Copy link

meta-cla bot commented Oct 2, 2025

Hi @rzikm!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@rzikm rzikm changed the title Enable conditional ASM language support in CMake Make ASM language conditional at CMake configure time Oct 2, 2025
@meta-cla
Copy link

meta-cla bot commented Oct 2, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Oct 2, 2025
@Cyan4973 Cyan4973 self-assigned this Oct 2, 2025
@Cyan4973 Cyan4973 added the build label Oct 2, 2025
@Shahinpar49
Copy link

Shahinpar49 commented Oct 2, 2025 via email

@rzikm
Copy link
Contributor Author

rzikm commented Oct 7, 2025

Hi, Is there anything else needed from my end to get this merged?

@Cyan4973
Copy link
Contributor

Cyan4973 commented Oct 7, 2025

Nope, I think that's good to go !

@Cyan4973 Cyan4973 merged commit 23dae4b into facebook:dev Oct 7, 2025
104 checks passed
@rzikm
Copy link
Contributor Author

rzikm commented Oct 7, 2025

@Cyan4973 Thanks, Also, how often do you release new versions? When can we reasonably expect v1.5.8?

@Cyan4973
Copy link
Contributor

Cyan4973 commented Oct 7, 2025

No ETA for v1.5.8. On short term, we are fully booked by another objective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants