Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 23, 2025

Fix variable name typos in automated_benchmarking.py

% ruff check tests/automated_benchmarking.py

Error: tests/automated_benchmarking.py:237:21: F821 Undefined name `baseline_label`
Error: tests/automated_benchmarking.py:250:21: F821 Undefined name `baseline_label`
Error: tests/automated_benchmarking.py:318:55: F821 Undefined name `frequenc`
Error: Process completed with exit code 1.

% ruff rule F821

Why is this bad?

An undefined name is likely to raise NameError at runtime.

@meta-cla meta-cla bot added the CLA Signed label Oct 23, 2025
@Cyan4973 Cyan4973 self-assigned this Oct 23, 2025
@Cyan4973
Copy link
Contributor

This looks good to me,

the errors reported in the cmake-mingw test seem unrelated to this PR,

@Cyan4973
Copy link
Contributor

Cyan4973 commented Oct 23, 2025

With #4516 merged, this should fix the test failing in this CI session.
You could rebase just to be sure.
Either way, I think it's fine.

Fix variable name typos in automated_benchmarking.py

% `ruff check`
```
Error: tests/automated_benchmarking.py:237:21: F821 Undefined name `baseline_label`
Error: tests/automated_benchmarking.py:250:21: F821 Undefined name `baseline_label`
Error: tests/automated_benchmarking.py:318:55: F821 Undefined name `frequenc`
Error: Process completed with exit code 1.
```
% [`ruff rule F821`](https://docs.astral.sh/ruff/rules/undefined-name)
@cclauss
Copy link
Contributor Author

cclauss commented Oct 23, 2025

rebassed.

@Cyan4973 Cyan4973 merged commit 4944d2c into facebook:dev Oct 23, 2025
104 checks passed
@cclauss cclauss deleted the patch-1 branch October 23, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants