fix: in zstd_edist in zstd_edist.c#4644
Open
orbisai0security wants to merge 1 commit intofacebook:devfrom
Open
fix: in zstd_edist in zstd_edist.c#4644orbisai0security wants to merge 1 commit intofacebook:devfrom
orbisai0security wants to merge 1 commit intofacebook:devfrom
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
contrib/match_finders/zstd_edist.c.Vulnerability
V-001contrib/match_finders/zstd_edist.c:416Description: In zstd_edist.c, three memcpy operations at lines 416, 430, and 435 copy match data into and out of combinedMatches without validating that nbCombinedMatches * sizeof(ZSTD_eDist_match) fits within the allocated buffer. If nbCombinedMatches is derived from attacker-controlled compressed input and exceeds the allocated capacity, the memcpy at line 435 writes beyond the heap buffer boundary, corrupting adjacent heap memory.
Changes
contrib/match_finders/zstd_edist.cVerification
Automated security fix by OrbisAI Security